Date: Tue, 29 Aug 2023 09:46:55 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	"robertmhaas@gmail.com" <robertmhaas@gmail.com>
Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
Message-ID: <20230829164655.GA2138073@nathanxps13>
References: 
 <CAB8KJ=j-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few@mail.gmail.com>
 <20230824023206.GA1128857@nathanxps13.lan>
 <20230824025140.GB1128857@nathanxps13.lan>
 <20230824161913.GA1394441@nathanxps13.lan>
 <CAB8KJ=iWYvB1odjFRZybsPeUV8HUAiVVjY9RMHSdvWy1t77cLg@mail.gmail.com>
 <20230825153251.GA1593219@nathanxps13>
 <20230825192949.GA1917227@nathanxps13>
 <CF0C64D6-BB5C-4F84-98BB-8852A1C01A40@amazon.com>
 <ZOv+MHonWVgW/bpf@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZOv+MHonWVgW/bpf@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20230829164655.GA2138073%40nathanxps13>
Precedence: bulk

On Mon, Aug 28, 2023 at 10:53:52AM +0900, Michael Paquier wrote:
> I understand that this is not a fantastic naming, but renaming
> pgstat_fetch_stat_local_beentry() to something like
> pgstat_fetch_stat_local_beentry_by_{index|position}_id() would make
> the difference much easier to grasp, and we should avoid the use of
> "beid" when we refer to the *position/index ID* in
> localBackendStatusTable, because it is not a BackendId at all, just a
> position in the local array.

This was my first reaction [0].  I was concerned about renaming the
exported functions so close to release, so I was suggesting that we hold
off on that part until v17.  If there isn't a concern with renaming these
functions in v16, I can proceed with something more like v2.

[0] https://postgr.es/m/20230824161913.GA1394441%40nathanxps13.lan

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com