Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qc7ak-00DtoH-8x for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Sep 2023 17:05:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qc7ai-00FvnV-Nv for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Sep 2023 17:05:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qc7ai-00FvnJ-D7 for pgsql-hackers@lists.postgresql.org; Fri, 01 Sep 2023 17:05:52 +0000 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qc7af-002Bgm-9O for pgsql-hackers@lists.postgresql.org; Fri, 01 Sep 2023 17:05:50 +0000 Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3a85c5854deso1494367b6e.0 for ; Fri, 01 Sep 2023 10:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693587948; x=1694192748; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9iEugQrxoZ9SCg8nuEczOe/4/2KvMyEJ4/eTO6trLBM=; b=Fn7WhU9rv4jxrVM/bWAIOdR6m6IAejD+nD9roViqEae7RdTe5X49xcZWS0jfCUuN+N L+IDWYSzjqorQA9h4/95m8vDg/gu1XttvrmWHorTmXXREY2VJr6MwM5Vn0/oyYDC2MsY 7XgBeXrV0FxVd2E0satRCtwrf1N7e/ZImCS3d0QBeIWKS9LiupxAfVQiVMAs0Tw2Nc+h 9pO74u3BAxdrvNlunQxcBeZwI7IyzZpk4zyuoxGka0CtF9IBfYK38IHcqrsYdqZZD6Sw gb6mFIXn25BxUpwQyB5Ws1vMjQvtgYoOar4auywghcSQGIQ0fKg0ie8fRs8J8jT98hKw 4ymA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693587948; x=1694192748; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9iEugQrxoZ9SCg8nuEczOe/4/2KvMyEJ4/eTO6trLBM=; b=k6FuVhZAzDqqGK/fQmAb5YTbdnEoef/Po426EuK5aO3JzyoSEj1wYY8QDhgySJE4q0 KEElUK7euxmzm+MBXUeqfCFd9NO7r1JxWKmcPE8SqfN6pMeJ80kkgiq1r3jenuKfbLop EjdeuvgTYdrwv6tq/6Oi96UXww9Z61gOOrh2BBZQBZpPgkl4cnWqvpm1Aq22wA1oSwq0 FCf8GJtpCoUI9SoEEaNorRYxI51h5uRomW36sDiqzjGfWgYQKla7+QGUidSyPBq6VXc/ SP8/1OgN7PFThL1Zq0jfRM/F4MVXVDq9BzPj4+O2CioFPIB7OxOafS9QjLQZKDKuAieq tSSQ== X-Gm-Message-State: AOJu0YyVlp4C4+9UmtEqSC25nwz7HSwo9mHG1gxS1svhvkxp/OADyyKL wLIYmNKKULFurDVrQhzXHX6WIJp8yUc= X-Google-Smtp-Source: AGHT+IGL4xEMfLWnpCzXZbD+k7We4A/joDFn2q8xy0k65jq4uhNxsCZRZGGR7bU2+fLbM4GZV66C9w== X-Received: by 2002:a05:6808:9a9:b0:3a8:7f65:a94 with SMTP id e9-20020a05680809a900b003a87f650a94mr3026611oig.42.1693587948657; Fri, 01 Sep 2023 10:05:48 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:ed2c:b641:352b:afe1]) by smtp.gmail.com with ESMTPSA id w22-20020a056808141600b003a72a979950sm2189508oiv.4.2023.09.01.10.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 10:05:48 -0700 (PDT) Date: Fri, 1 Sep 2023 10:05:46 -0700 From: Nathan Bossart To: Tom Lane Cc: Alvaro Herrera , Andrew Dunstan , pgsql-hackers@lists.postgresql.org Subject: Re: Inefficiency in parallel pg_restore with many tables Message-ID: <20230901170546.GC3178187@nathanxps13> References: <20230718045701.GA1090171@nathanxps13> <20230718160511.loirkf5fwjm5ut73@alvherre.pgsql> <20230718160713.GA1139177@nathanxps13> <20230720190644.GA1724613@nathanxps13> <20230722231941.GA2020225@nathanxps13> <1225141.1690069670@sss.pgh.pa.us> <20230723055703.GA2421212@nathanxps13> <20230724190015.GA2528613@nathanxps13> <20230725185336.GA2911441@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725185336.GA2911441@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jul 25, 2023 at 11:53:36AM -0700, Nathan Bossart wrote: > Here is a polished patch set for this approach. I've also added a 0004 > that replaces the open-coded heap in pg_dump_sort.c with a binaryheap. > IMHO these patches are in decent shape. I'm hoping to commit these patches at some point in the current commitfest. I don't sense anything tremendously controversial, and they provide a pretty nice speedup in some cases. Are there any remaining concerns? -- Nathan Bossart Amazon Web Services: https://aws.amazon.com