Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiMCk-006CGw-24 for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Sep 2023 21:54:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qiMCi-003t58-Lr for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Sep 2023 21:54:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiMCi-003t4h-By for pgsql-hackers@lists.postgresql.org; Mon, 18 Sep 2023 21:54:52 +0000 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qiMCb-005KOP-GC for pgsql-hackers@lists.postgresql.org; Mon, 18 Sep 2023 21:54:51 +0000 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-573449a364fso3285856eaf.1 for ; Mon, 18 Sep 2023 14:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695074085; x=1695678885; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bmX09CVz0vD9ZYx4Xp6FxXsZsCd5AuHDWKbzxm7WBww=; b=VNoowIGp0y+TZOCy6aFJYHv3MmjGcwD6PegUxFjNneIth5dbKJMrI9lNpfi1Pkg02K prYGvFdksq4RiUZkvir7//at3BeeYrU9/9MpMtzR7VBLwxzPpIJtxU+watvTEkmVOtG8 7kr3k2BRMrJQuj0TkAh6YJtWfSQ/LXLR+rz+YPei1XtC6uRGuXop1lbsuP1z9OuSGbJi eQfyKJJ62vmXYhUnd2YE+u2zNR7R2UaNrxVDeyrkJqSNWX0mai2mojeBZ1Iq3emAA5N9 2T4zXOciR0+hbHkZWklRS7mXHqoHRmBGyHgUbNvPyggOAIzMauG2BcMkiHARR7Zd/mhb uzeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695074085; x=1695678885; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bmX09CVz0vD9ZYx4Xp6FxXsZsCd5AuHDWKbzxm7WBww=; b=ADihFABgaHkRDQTL8b7N8hbY0RHv21TfwL3W6KAmoXZZoUd+Dp9ENKi5QK4Zp4p6eB c5kW7ed/q4pJySzM0+6/WMarGkGAzFhfLADCX+GPKUxU7DpaCTZ/5Jon/FbBZdHVCglt n95zPQ/XisGKURncFR8YTOq6K/6tGBfQQl6W106TAukYs6huY9iJtuJXWEIHOoxXmOln apFe2zoc925xARMA0qLnXOmkknh4jUqMKRdF8Qf3PWwNSoDf/YPucoSdUGxOd2NbIfVt FXcjGLd/VaK9F8LfhdNG2EB631Gap5+ggd3a8/m64YYOLbWnO7yx3Fk5Tm1gAmR3xn+Y Okrg== X-Gm-Message-State: AOJu0Yy362IVlXVnJ9cVu/7aUvxn2iqeXN95U7ic2u8qNedaOAC4NKZM oPFRdKrrlTjC/IgNbjpoNcBkbtQh1F8= X-Google-Smtp-Source: AGHT+IE88Ms7tH8UcfP7M/QdqzTAT7xTCP89kgteyTdzYbdKjh2js1rMvrnSJ05ZFmyXqC88TcswdA== X-Received: by 2002:a4a:7652:0:b0:573:f620:ec80 with SMTP id w18-20020a4a7652000000b00573f620ec80mr9455135ooe.2.1695074084931; Mon, 18 Sep 2023 14:54:44 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:d13d:716d:771a:5b2c]) by smtp.gmail.com with ESMTPSA id j4-20020a4aab44000000b00576161c4315sm4527066oon.37.2023.09.18.14.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 14:54:44 -0700 (PDT) Date: Mon, 18 Sep 2023 14:54:42 -0700 From: Nathan Bossart To: Pierre Ducroquet Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Improvements in pg_dump/pg_restore toc format and performances Message-ID: <20230918215442.GB2661288@nathanxps13> References: <2656000.KRxA6XjA2N@peanuts2> <20230918215247.GA2661288@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230918215247.GA2661288@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Sep 18, 2023 at 02:52:47PM -0700, Nathan Bossart wrote: > On Thu, Jul 27, 2023 at 10:51:11AM +0200, Pierre Ducroquet wrote: >> I ended up writing several patches that shaved some time for pg_restore -l, >> and reduced the toc.dat size. > > I've only just started taking a look at these patches, and I intend to do a > more thorough review in the hopefully-not-too-distant future. Since cfbot is failing on some pg_upgrade and pg_dump tests, I've set this to waiting-on-author. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com