Feedback-ID: ia2694551:Fastmail
Date: Wed, 20 Sep 2023 19:58:07 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tristan Partin <tristan@neon.tech>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade --check fails to warn about abstime
Message-ID: <202309201758.vox63zqcqpi4@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CVNXKGJRAAWS.25S80HUEMM7II@neon.tech>
Archived-At: 
 <https://www.postgresql.org/message-id/202309201758.vox63zqcqpi4%40alvherre.pgsql>
Precedence: bulk

On 2023-Sep-20, Tristan Partin wrote:

> > +/*
> > + * check_for_removed_data_type_usage
> > + *
> > + *        similar to the above, but for types that were removed in 12.
> > + */
> > +static void
> > +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *datatype)
> 
> Seems like you could make this more generic instead of hardcoding version
> 12, and then you could use it for any future removed types as well.

Yeah, I thought about that, and then closed that with "we can whack it
around when we need it".  At this point I imagine there's very few other
datatypes we can remove from the core server, if any.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)