Date: Wed, 20 Sep 2023 12:07:48 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Maxim Orlov <orlovmg@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Bruce Momjian <bruce@momjian.us>, Paul Guo <guopa@vmware.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Michael Brown <michael.brown@discourse.org>,
	pgsql-hackers@postgresql.org
Subject: Re: should frontend tools use syncfs() ?
Message-ID: <20230920190748.GA2960472@nathanxps13>
References: <YVUz0Ay9KshniWBe@paquier.xyz>
 <20220413115412.GM26620@telsasoft.com>
 <20230729214010.GA189456@nathanxps13>
 <ZPImMi8smaPsXjGK@pryzbyj2023>
 <20230901180851.GC3180181@nathanxps13>
 <ZPIrISXQz1FOsh6/@pryzbyj2023>
 <20230901183100.GD3180181@nathanxps13>
 <20230906000853.GA105086@nathanxps13>
 <20230906232908.GA537242@nathanxps13>
 <CACG=ezbL1gwE7_K7sr9uqaCGkWhmvRTcTEnm3+X1xsRNwbXULQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CACG=ezbL1gwE7_K7sr9uqaCGkWhmvRTcTEnm3+X1xsRNwbXULQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230920190748.GA2960472%40nathanxps13>
Precedence: bulk

On Wed, Sep 20, 2023 at 03:12:56PM +0300, Maxim Orlov wrote:
> As a solution, I suggest renaming sync_method in xlog module to
> wal_sync_method. In fact,
> appropriate GUC for this variable, called "wal_sync_method" and I see no
> reason not to use
> the exact same name for a variable in xlog module.

+1

I think we should also consider renaming things like SYNC_METHOD_FSYNC to
WAL_SYNC_METHOD_FSYNC, and sync_method_options to wal_sync_method_options.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com