Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qktws-00HPxe-Sj for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Sep 2023 22:21:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qktwr-005OfJ-Df for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Sep 2023 22:21:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qktwr-005Oex-32 for pgsql-hackers@lists.postgresql.org; Mon, 25 Sep 2023 22:21:01 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qktwo-006cyO-Eo for pgsql-hackers@lists.postgresql.org; Mon, 25 Sep 2023 22:20:59 +0000 Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-d867d4cf835so4876165276.1 for ; Mon, 25 Sep 2023 15:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695680457; x=1696285257; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WNwAq44aqLxxn5YOo+WY81N2rDHPSMr/o9TCtOmdbK0=; b=VT2/klLhUoFMU8AIYPCJ21hE1UjkXVL/hmhBiJRmz2kSWaKeLJVsGv8v0aAHFgHDz7 LIPmiKVX4MZgaCB0Le7ILo3GK9OzGksK0Wj3Ucm2Grj5lSKWt2FjAS0sQPDQdsCh5KT2 e05Rh0lhWbh9qz3q0IUwKb7wqEJX6G+vlRCbLIfG1+NK5wljhNcLnKqi5aSaCJYKXMsw rlCRpWo/xUra/BeZdSx0pff1GVW6fQZJf3iIi8SAedXeLrgmFjSNIHkRi9ikXglLtk4v apPEFFSBfdaA1oZ7WypyC8MgQFd12iPT97i7JwdqsvcTQVrFhfhbFY/qoVXAIydTeDKq X+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695680457; x=1696285257; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WNwAq44aqLxxn5YOo+WY81N2rDHPSMr/o9TCtOmdbK0=; b=OHLwZsALJRc3Y5XTpmxdVaSTR4B+2EIJ5/FovhbO5rz9hXhg2sQ4t+mI1idiIKUJbH pLyvjMwig5DbWiSGZBdUorhktgAR7ySyTYYtRqHd/OYhZPXSeqwxcl3GRR/UP4D56Wgd pdBhVFis0HuARsA1nwaVnAtnSCxEnUXcE95XbVoNlbEw79qTfZNSQdnhRnv3TEKXvnmD bZokEUnhPSP06gHNqMvm1XHOi818yRclAJtb46jDozsrystZ6uPmyAxqkBzBogUaOiEf HicuBGzj9jYxzgQ6PSQEYKYmvT19wzXg2FPyJknx0GllblQUj2u2eD8pYEQx43SAnda3 W44w== X-Gm-Message-State: AOJu0Yz7GUKRLiJ5TIN1lxD98Lm74ouN/iJph5BrViyP0FV11mGm9hFv ofb5ixCWkTQQkoaVU+WtMKw= X-Google-Smtp-Source: AGHT+IH20dx9VA464EDum6JOqqPOlmzoX3Lk41KdCjEhfHRGTzp315octHZu82Cdb6r0X1q2DHpZEA== X-Received: by 2002:a25:258d:0:b0:c3c:5eb1:e975 with SMTP id l135-20020a25258d000000b00c3c5eb1e975mr7828461ybl.47.1695680457579; Mon, 25 Sep 2023 15:20:57 -0700 (PDT) Received: from nathanxps13 ([216.250.210.89]) by smtp.gmail.com with ESMTPSA id b8-20020a0cf048000000b0065b08bb01afsm1490980qvl.124.2023.09.25.15.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 15:20:57 -0700 (PDT) Date: Mon, 25 Sep 2023 15:20:47 -0700 From: Nathan Bossart To: bt23nguyent Cc: Daniel Gustafsson , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set Message-ID: <20230925222047.GA3173226@nathanxps13> References: <202309151049.dmfsxc5b3wyf@alvherre.pgsql> <7035FAFE-7E91-4B31-AA72-75EE82DB3F7B@yesql.se> <20230915143827.GA1912920@nathanxps13> <85b9e69997bbd5d8302a3a99a2de246d@oss.nttdata.com> <18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Sep 21, 2023 at 11:18:00AM +0900, bt23nguyent wrote: > -basic_archive_configured(ArchiveModuleState *state) > +basic_archive_configured(ArchiveModuleState *state, char **logdetail) Could we do something more like GUC_check_errdetail() instead to maintain backward compatibility with v16? -- Nathan Bossart Amazon Web Services: https://aws.amazon.com