Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qlk2u-004A3C-K3
	for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Sep 2023 05:58:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qlk2s-009FTU-KZ
	for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Sep 2023 05:58:43 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <kop@karlpinc.com>)
	id 1qlk2s-009FT1-A2
	for pgsql-hackers@lists.postgresql.org; Thu, 28 Sep 2023 05:58:42 +0000
Received: from janus.karlpinc.com ([173.161.46.12] helo=smtp.karlpinc.com)
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <kop@karlpinc.com>)
	id 1qlk2p-0073zR-NX
	for pgsql-hackers@lists.postgresql.org; Thu, 28 Sep 2023 05:58:41 +0000
Received: from slate.karlpinc.com (unknown [192.168.1.14])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by smtp.karlpinc.com (Postfix) with ESMTPS id 33622A25A;
	Thu, 28 Sep 2023 00:58:36 -0500 (CDT)
Received: from slate.karlpinc.com (localhost [IPv6:::1])
	by slate.karlpinc.com (Postfix) with ESMTPS id C62A93FCAF;
	Thu, 28 Sep 2023 00:58:35 -0500 (CDT)
Date: Thu, 28 Sep 2023 00:58:28 -0500
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Peter Smith
 <smithpb2250@gmail.com>, jian he <jian.universality@gmail.com>, Postgres
 hackers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [PGdocs] fix description for handling pf non-ASCII characters
Message-ID: <20230928005828.549a23a1@slate.karlpinc.com>
In-Reply-To: <ZRT4-SwWgM9oEil9@paquier.xyz>
References: <TYAPR01MB5866CD2A823B196FBE7F19B9F52EA@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<20230926010328.2c556046@slate.karlpinc.com>
	<TYAPR01MB586607D53C42E59DBB00FD9AF5C3A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<20230926124553.6884c912@slate.karlpinc.com>
	<TYAPR01MB58663EB061888B2715A39217F5C2A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<20230927085924.4198c3d2@slate.karlpinc.com>
	<CAHut+PsfF5vTcgB3gTEkZPsbs-WGN4ENdKhz_G2YpMx3P8s02A@mail.gmail.com>
	<20230927193036.121f6474@slate.karlpinc.com>
	<TYAPR01MB5866DD962CA4FC03E338C6BBF5C1A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<TYAPR01MB586639C3B11FB5C9EE30AA29F5C1A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<ZRT4-SwWgM9oEil9@paquier.xyz>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20230928005828.549a23a1%40slate.karlpinc.com>
Precedence: bulk

On Thu, 28 Sep 2023 12:54:33 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> I was looking at this thread overall, the three v3 flavors of the doc
> changes and v4.
> 
> -        <varname>application_name</varname> value. Other characters
> will be
> -        replaced with question marks (<literal>?</literal>).
> +        <varname>application_name</varname> value.
> +        Other characters are replaced with <link
> +        linkend="sql-syntax-strings-escape">C-style hexadecimal
> escapes</link>.
> 
> The simplicity of the change in v4 seems like the best approach to me,
> so +1 for that (including the mention to "C-style").

I agree with Tom that it's not worth spending anyone's attention
on bytes v.s. characters.

So I'm marking the patch ready for committer.
(I have not tried the version that patches against PGv16.)

Thank you everyone, especially Hayato, for spending time
and making this better.

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein