Feedback-ID: ia2694551:Fastmail
Date: Thu, 28 Sep 2023 15:41:06 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, 
	Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Subject: Re: Is it worth adding Assert(false) for unknown paths in
 print_path()?
Message-ID: <202309281341.o6n3nglxq2rx@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAApHDvrNB2maad+O+rUGV1Fzj=WQHiJTXSfQx5KBFDxyfjmbeA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/202309281341.o6n3nglxq2rx%40alvherre.pgsql>
Precedence: bulk

On 2023-Sep-29, David Rowley wrote:

> In [1] Andrey highlighted that I'd forgotten to add print_path()
> handling for TidRangePaths in bb437f995.
> 
> I know the OPTIMIZER_DEBUG code isn't exactly well used.  I never
> personally use it and I work quite a bit in the planner, however, if
> we're keeping it, I thought maybe we might get the memo of missing
> paths a bit sooner if we add an Assert(false) in the default cases.
> 
> Is the attached worthwhile?

Hmm, if we had a buildfarm animal with OPTIMIZER_DEBUG turned on, then I
agree it would catch the omission quickly.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)