public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alvaro Herrera <[email protected]>
To: Amit Langote <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Erik Rijkers <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: jian he <[email protected]>
Subject: Re: remaining sql/json patches
Date: Fri, 6 Oct 2023 12:01:05 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+HiwqGGJtcVP=EGP0hH1Q6EqJE99KnOQvibC18QnepsWVu9fQ@mail.gmail.com>
On 2023-Oct-06, Amit Langote wrote:
> 2. Assignment of op->d.iocoerce.escontext needed to be changed like this:
>
> v_params[4] = l_ptr_const(op->d.iocoerce.escontext,
> -
> l_ptr(StructErrorSaveContext));
> + l_ptr(StructNode));
Oh, so you had to go back to using StructNode in order to get this
fixed? That's weird. Is it just because InputFunctionCallSafe is
defined to take fmNodePtr? (I still fail to see that a pointer to
ErrorSaveContext would differ in any material way from a pointer to
Node).
Another think I thought was weird is that it would only crash in LLVM5
debug and not the other LLVM-enabled animals, but looking closer at the
buildfarm results, I think that may have been only because you reverted
too quickly, and phycodorus and petalura didn't actually run with
7fbc75b26ed8 before you reverted it. Dragonet did make a run with it,
but it's marked as "LLVM optimized" instead of "LLVM debug". I suppose
that must be making a difference.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"World domination is proceeding according to plan" (Andrew Morton)
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: remaining sql/json patches
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox