public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Included xid in restoring reorder buffer changes from disk log message
Date: Tue, 10 Oct 2023 10:29:05 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALDaNm3-MTwMkeuWfVr22_B123M8D9PNn8TwCwmp40BFarAw7w@mail.gmail.com>
References: <CALDaNm2Kak-dsJ8Rbf0_-7J9KEUwNNqB8=kJvjTrCMy9t9X7=g@mail.gmail.com>
	<CAFiTN-u336x+pD8NHuLQvz-k+VE3H8=_+XTLH_gMNX23i2y0Xw@mail.gmail.com>
	<CALDaNm3-MTwMkeuWfVr22_B123M8D9PNn8TwCwmp40BFarAw7w@mail.gmail.com>

At Fri, 6 Oct 2023 14:58:13 +0530, vignesh C <[email protected]> wrote in 
> On Fri, 30 Apr 2021 at 11:53, Dilip Kumar <[email protected]> wrote:
> > It makes sense to include xid in the debug message, earlier I thought
> > that will it be a good idea to also print the toplevel_xid.  But I
> > think it is for debug purposes and only we have the xid we can fetch
> > the other parameters so maybe adding xid is good enough.

+1

> While having a look at the reorderbuffer code, I noticed that this
> changes were still not committed.
> Here is a rebased version of the patch.

While this patch makes the following change on the de-serializing side;

-			elog(DEBUG2, "restored %u/%u changes from disk",
+			elog(DEBUG2, "restored %u/%u changes of XID %u from disk",

the counter part ReorderBufferSerializeTXN() has the following
message.

> 	elog(DEBUG2, "spill %u changes in XID %u to disk",
>		 (uint32) txn->nentries_mem, txn->xid);

It might be preferable for those two messages to have a corresponding
appearance.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Included xid in restoring reorder buffer changes from disk log message
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox