Date: Fri, 13 Oct 2023 11:37:30 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
	David Geier <geidav.pg@gmail.com>, Sergei Kornilov <sk@zsrv.org>,
	Michael Paquier <michael@paquier.xyz>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Marcos Pegoraro <marcos@f10.com.br>,
	vignesh C <vignesh21@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>, Zhihong Yu <zyu@yugabyte.com>,
	David Steele <david@pgmasters.net>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Pavel Trukhanov <pavel.trukhanov@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_stat_statements and "IN" conditions
Message-ID: <20231013163730.GA1362765@nathanxps13>
References: <20230211120820.y7krq37jubnjsa5b@erthalion.local>
 <07919318-6c35-a13f-6a1d-98686a3e38de@gmail.com>
 <20230217154602.uf3a3cgqeoeysycz@erthalion.local>
 <8702fa3e-5aac-dcf0-161b-faa2b9eadad6@gmail.com>
 <20230226104619.jfmwrpd5zrkmp3eu@erthalion.local>
 <CAM-w4HO29FpoX5oYR7tuxP9sZA1s3zLV94c_79h_uQeNHUjhyQ@mail.gmail.com>
 <20230314190432.l4oe3wa3pvt5b7hx@erthalion.local>
 <20230319122734.xkba536kut3g4gcy@erthalion.local>
 <20230704044611.GA3373000@nathanxps13>
 <20230704190256.arszjcwvrjekxj25@ddolgov.remote.csb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230704190256.arszjcwvrjekxj25@ddolgov.remote.csb>
Archived-At: <https://www.postgresql.org/message-id/20231013163730.GA1362765%40nathanxps13>
Precedence: bulk

On Tue, Jul 04, 2023 at 09:02:56PM +0200, Dmitry Dolgov wrote:
>> On Mon, Jul 03, 2023 at 09:46:11PM -0700, Nathan Bossart wrote:
>> Also, it seems counterintuitive that queries with fewer than 10
>> constants are not merged.
> 
> Why? What would be your intuition using this feature?

For the "powers" setting, I would've expected queries with 0-9 constants to
be merged.  Then 10-99, 100-999, 1000-9999, etc.  I suppose there might be
an argument for separating 0 from 1-9, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com