Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsnCA-009RVz-Ft for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 16:45:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qsnC7-00CLQD-Lc for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 16:45:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsnC7-00CLPc-CW for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 16:45:24 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qsnC5-000wvn-1C for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 16:45:22 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3af6bd48093so3869826b6e.3 for ; Tue, 17 Oct 2023 09:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697561120; x=1698165920; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vax+m511eERQuaOJhnxPahkFe++mNjYXViyzuPuIC1s=; b=BLodSRVU/S9S5NohDJySUDCIV3VqW2Lr/wANbHN6klHY8HCiJEtTIfoZ2bLbS0TRvg RD/yO8YAWb55JCsbqmmr/ZNan5XcCNyrCWH8PPdsVafHQYRxr92Ehf1IvR7GC4e6PdjN zI3a/mMdj2rM9qdun7HQucKtocWsafYxt6U6GcnQvyT7nbhFUDjXVHeoZsVHHHAlbMs/ pA+iR6qJYB/fg/iTHQTy8HIG4U9XzJnFHuB3/DaO2PUtonjF7Mmsna/+tXQSItboIXQU uWDejM8xhKCcj0HXc7RAFmJgG4x9wMVpn6QzTF+belG6C/XD+s5B992lN+3oQUuWnSQa xN1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697561120; x=1698165920; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vax+m511eERQuaOJhnxPahkFe++mNjYXViyzuPuIC1s=; b=Kj/oXZME//YkB30AUX4zZgDODSEU9upfcYJ9NDpJzBJN2glRQ4bVpRG6nqENVB6zge GKWeJg7H8R5d8jJ7/+Bl39K+rvIVZ2rpchN5DWvqUMXeRYJoLaZ4ImjCDpMowBxwK/Ii NAzqCNFEA1aXA/VeA80QMb2GKQPtr8r3j+zoRf7nlS3AnSrmqlJWjmjjrnvVDKlDRDyv iN5IQShYqqMEg0O0pjCQJSikyas6yzvYhMCEK/JaCQU6G4lN6cvcsv/9/iURZYKU/XQ1 6uAWWfeGCZHp17NXuVUr73xtLpoZ6WnKk1FrJwCe1cyBDyAHtu5EPLly1l8AH0qIxxm5 RB2Q== X-Gm-Message-State: AOJu0YzatGcRp1ek+/8NVLMyq0j7oD3rH/k/Yaazv+8jAsKzzOx+Yyw2 Y2KxOniAkRHkB/NGSl9AEH9ynGPR4Y4= X-Google-Smtp-Source: AGHT+IGBe+Pj3ujni/9eAaqats3RP9oVtp7qkpHyVq7lK8u9HYLParERSJdjSrHHuPGkU4nmEmF5fQ== X-Received: by 2002:a05:6808:2918:b0:3af:639d:ead6 with SMTP id ev24-20020a056808291800b003af639dead6mr2699251oib.36.1697561120363; Tue, 17 Oct 2023 09:45:20 -0700 (PDT) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id t10-20020a056638204a00b00439f2a2cdfbsm590225jaj.138.2023.10.17.09.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 09:45:19 -0700 (PDT) Date: Tue, 17 Oct 2023 11:45:17 -0500 From: Nathan Bossart To: Michael Paquier Cc: Andres Freund , Thomas Munro , Robert Haas , Tom Lane , Fujii Masao , Postgres hackers Subject: Re: stopgap fix for signal handling during restore_command Message-ID: <20231017164517.GA613565@nathanxps13> References: <20230226201227.cner3cdicropu4q5@awork3.anarazel.de> <20230301043603.GD1453450@nathanxps13> <20230301224751.GA1823946@nathanxps13> <20231010234028.iba6wotmp22poxoh@awork3.anarazel.de> <20231011025418.GA845134@nathanxps13> <20231011032934.GA847236@nathanxps13> <20231011033929.j7doct7wzmyw6xiu@awork3.anarazel.de> <20231011190000.GA894647@nathanxps13> <20231017154647.GA611717@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017154647.GA611717@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Oct 17, 2023 at 10:46:47AM -0500, Nathan Bossart wrote: > Committed and back-patched. ... and it looks like some of the back-branches are failing for Windows. I'm assuming this is because c290e79 was only back-patched to v15. My first instinct is just to back-patch that one all the way to v11, but maybe there's an alternative involving #ifdef WIN32. Are there any concerns with back-patching c290e79? -- Nathan Bossart Amazon Web Services: https://aws.amazon.com