Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsrRw-009oQ0-2d for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 21:18:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qsrRt-00EXqz-3o for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 21:17:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsrRs-00EXqq-JF for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 21:17:57 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qsrRm-000yqT-D9 for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 21:17:55 +0000 Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-79fa7e33573so249773439f.0 for ; Tue, 17 Oct 2023 14:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697577469; x=1698182269; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4VJ6E56q1/kr0req4eLTty79xj4BoLcOnAU8/+0zS+s=; b=AtS1E8Hkr6541jWjrBT7yUaPAhClWfJHwqsv3p0E/TD+Wtq9DyS2LzrG5mRg6jH49g 1HOSdfvGdKgT85uV9qvhXkaEdQ0m8HITOJpCUDqfz2SfRZealJOwfADPhAhj4CBd3InQ Ih3bDsxgjfYVpGtALEKaO7OVBGkqoYnc45x5HDVyp9ii9sKOqHLK+Gp00iDg225iINRN YUFYZmrFTY8JVuWKe/zid0n4mXau1mvry49dDWoLLVc0vDsqJcDbxLfH7TnL5k+ifO47 v13VoTATYXXrw/L9uAhIl20pqjs7ViF3Kjjr5tmIb/tilCjqVXeAYbtPpwN5k2/gE1u3 t+0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697577469; x=1698182269; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4VJ6E56q1/kr0req4eLTty79xj4BoLcOnAU8/+0zS+s=; b=tJ9GJpt2L9/FsFTd4Y6IGbd1CGl5yTcfvn3pIlzVByqZVbxtRwfC6sd+a+ij4QakwM z5uLcAT246VN7lPwjo1yBryFfL/Mt5q1gCJsE160JI2TY+Thi4JlcRVBn0rjBiwwJPDk z5d11Ul1nEcGK0hwSUubTnje8RKNYLyH2aNAfUC81KgoU91HblM6Oo9ISc6h/PH8O2pP 4Goh3xnWOemyF6cORwsvgVYSW6Z3kIRj3MymVoY+aABqyrdX7z+GvV4MZFKuf5mjuhBH BF+jlMjbvxGGQHtrEBvMRjJoe+s4fo/w80QJMaskD0A8ihnEqjYkbv7W8eHSr/8F8sGy hrQQ== X-Gm-Message-State: AOJu0YykaU5hfBfht3OGje722r+YPddPhuegNNfzzH7mnYKPnEgrkDt+ LsbFL7t3kpsZ+ec3t4vIFDU= X-Google-Smtp-Source: AGHT+IGLUTqmIsUf6Y2TDaZlCRCEq8ugZS7UjfFL2VmeaImOxnl9PlcHCCU1bzmWz/f8dC+5NBGjDA== X-Received: by 2002:a05:6602:2a47:b0:795:2274:1f3f with SMTP id k7-20020a0566022a4700b0079522741f3fmr4308762iov.3.1697577468795; Tue, 17 Oct 2023 14:17:48 -0700 (PDT) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id q7-20020a056638040700b0045a1d21644dsm759009jap.40.2023.10.17.14.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 14:17:48 -0700 (PDT) Date: Tue, 17 Oct 2023 16:17:46 -0500 From: Nathan Bossart To: Tom Lane Cc: Michael Paquier , Andres Freund , Thomas Munro , Robert Haas , Fujii Masao , Postgres hackers Subject: Re: stopgap fix for signal handling during restore_command Message-ID: <20231017211746.GA823296@nathanxps13> References: <20230301224751.GA1823946@nathanxps13> <20231010234028.iba6wotmp22poxoh@awork3.anarazel.de> <20231011025418.GA845134@nathanxps13> <20231011032934.GA847236@nathanxps13> <20231011033929.j7doct7wzmyw6xiu@awork3.anarazel.de> <20231011190000.GA894647@nathanxps13> <20231017154647.GA611717@nathanxps13> <20231017164517.GA613565@nathanxps13> <2820645.1697561249@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2820645.1697561249@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Oct 17, 2023 at 12:47:29PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> ... and it looks like some of the back-branches are failing for Windows. >> I'm assuming this is because c290e79 was only back-patched to v15. My >> first instinct is just to back-patch that one all the way to v11, but maybe >> there's an alternative involving #ifdef WIN32. Are there any concerns with >> back-patching c290e79? > > Sounds fine to me. Thanks, done. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com