Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qvk4v-0072a7-3e
	for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Oct 2023 20:02:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qvk4t-007vFT-Ho
	for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Oct 2023 20:02:07 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1qvk4t-007vFL-85
	for pgsql-hackers@lists.postgresql.org; Wed, 25 Oct 2023 20:02:07 +0000
Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1qvk4q-002I88-GQ
	for pgsql-hackers@postgresql.org; Wed, 25 Oct 2023 20:02:06 +0000
Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3576e74ae9dso453835ab.3
        for <pgsql-hackers@postgresql.org>; Wed, 25 Oct 2023 13:02:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1698264124; x=1698868924; darn=postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=SJ61XWqRLW7JwEh3XcLew1dABQFLn9BRJqPVy7t8PJ4=;
        b=MApEnkuMxBhaR0q1F+F7wXUItGaDljmotu4eYJg0vuCYKnbNjDqJxIzrjwelPEbhKl
         4BRk3acd1Li40KxzY+zCAkSWzvzb2Cl8kPQaBI1IFCABnk9tvYJYvxVy9PMAYN65dwiG
         xPf9nkjQGa7ImEZ0MFGmxI1+myY6ew04QynGcZVT9llJbrGVmUg6HP/CsZuHRPTHH+R6
         mzjlpscwHpYUFFCSapx1vuSjMZo6aMjU/Hnyc7o822lq6ASCajXnfsTjcpHgSe2lSoij
         TnuljCIcwjdfa+Ht4Gv9LqRzTSnuO2+F1vYNggsDCgGPtYVpPkJ1RUrjO5uVPhCcn0fb
         SdMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1698264124; x=1698868924;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=SJ61XWqRLW7JwEh3XcLew1dABQFLn9BRJqPVy7t8PJ4=;
        b=X+dejRvpRNYVr9YPIxoNZEgtSJAYFtfTmv39sm96DdthLMRaMOjqhgqcCbL+cgO0wo
         xY0zDLftRtKUCex7C71nQeJKnMEuApirzf5Vch6+Q9cR1u5B4yzV2i5o8QUiBz33QeGH
         Lk4jKMiHThyDjCreaEWttJPofsk79f5okt2QIA5SINCAfB8LG6C65AwM/AS7GKUheIh8
         2TbKr3XIb83SBnLL8O5tdEJc/54x59CUExhap1KOoFwk/kMS7MUMpCcYaEFid+Gr62/E
         JIMu0fgAMAlQpA3E0r8rAg1OtGJj8BhAWYLReiDwpTz29mCWKd/uVr20Tv5xeaJiNnnA
         mOzw==
X-Gm-Message-State: AOJu0YzzJ5mlw18jdUnmynLBBWr0IOiDJGTXHJzfWnRw20OO9OW/izep
	4i8nqzfM/vVREXdSv4SVujtUCe1Dsg4=
X-Google-Smtp-Source: AGHT+IFW2Q23KPnzcexl4NfUuMJjrrw/EETaAM6ub7q6FLgGYwz3qcXdm/WkrG4PKz30jEKYBgYB4g==
X-Received: by 2002:a05:6e02:80a:b0:357:42cb:b3f6 with SMTP id u10-20020a056e02080a00b0035742cbb3f6mr15132876ilm.27.1698264123732;
        Wed, 25 Oct 2023 13:02:03 -0700 (PDT)
Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id a15-20020a92c70f000000b00351fc26191esm3927596ilp.83.2023.10.25.13.02.02
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 25 Oct 2023 13:02:03 -0700 (PDT)
Date: Wed, 25 Oct 2023 15:02:01 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: Remove dead code in pg_ctl.c
Message-ID: <20231025200201.GA990688@nathanxps13>
References: <0c742f0c-d663-419d-b5a7-4fe867f5566c@pgmasters.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0c742f0c-d663-419d-b5a7-4fe867f5566c@pgmasters.net>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20231025200201.GA990688%40nathanxps13>
Precedence: bulk

On Wed, Oct 25, 2023 at 02:53:31PM -0400, David Steele wrote:
> It looks like this code was missed in 39969e2a when exclusive backup was
> removed.

Indeed.  I'll plan on committing this shortly.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com