Date: Thu, 02 Nov 2023 11:03:35 +0900 (JST)
Message-Id: <20231102.110335.1808777803530400869.horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: robertmhaas@gmail.com, david@pgmasters.net,
 pgsql-hackers@lists.postgresql.org, zxwsbg12138@gmail.com,
 david.zhang@highgo.ca, andres@anarazel.de
Subject: Re: Requiring recovery.signal or standby.signal when recovering
 with a backup_label
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <ZUGQJQjV3QqH0rRd@paquier.xyz>
References: <ZUBM6BNQnEh7lzIM@paquier.xyz>
	<CA+TgmoYmWhN4u4zxmdYciaHJZdqkGKzpn==sbSOeRP8PJFSvoA@mail.gmail.com>
	<ZUGQJQjV3QqH0rRd@paquier.xyz>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20231102.110335.1808777803530400869.horikyota.ntt%40gmail.com>
Precedence: bulk

At Wed, 1 Nov 2023 08:39:17 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> See in StartupXLOG(), around the comment "complain if we did not roll
> forward far enough to reach".  This complains if archive recovery has
> been requested *or* if we retrieved a backup end LSN from the
> backup_label.

Please note that backupStartPoint is not reset even when reaching the
backup end point during crash recovery. If backup_label enforces
archive recovery, I think this point won't be an issue as you
mentioned. For the record, my earlier proposal aimed to detect
reaching the end point even during crash recovery.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center