Feedback-ID: ia2694551:Fastmail
Date: Wed, 8 Nov 2023 13:32:41 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Message-ID: <202311081232.rn3aho5ay6yx@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3B08E3F2-37C8-4D26-BA80-C4C0F4DF3848@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/202311081232.rn3aho5ay6yx%40alvherre.pgsql>
Precedence: bulk

On 2023-Nov-08, Daniel Gustafsson wrote:

> Since test_setup.sql is part of the regress schedule and not pg_regress we
> would have to implement this for each test run (regress, contribs etc), which
> is what Peter didn't like about the original suggestion.

Oh, somehow that aspect of his reply failed to register with me.  I
agree with your approach of using libpq in pg_regress then.

I suppose you're just thinking of using PQexec() or whatever, run one
query with sufficient ORDER BY, save the result, and at the end of the
test run just run the same query and compare that they are cell-by-cell
identical?  This sounds a lot simpler than the patch you posted.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/