Date: Thu, 16 Nov 2023 09:46:22 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Do away with a few backwards compatibility macros
Message-ID: <20231116154622.GA2881373@nathanxps13>
References: <CALj2ACVeO58JM5tK2Qa8QC-=kC8sdkJOTd4BFU=K8zs4gGYpjQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALj2ACVeO58JM5tK2Qa8QC-=kC8sdkJOTd4BFU=K8zs4gGYpjQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20231116154622.GA2881373%40nathanxps13>
Precedence: bulk

On Thu, Nov 16, 2023 at 07:11:41PM +0530, Bharath Rupireddy wrote:
> After a recent commit 6a72c42f (a related discussion [1]) which
> removed MemoryContextResetAndDeleteChildren(), I think there are a
> couple of other backward compatibility macros out there that can be
> removed. These macros are tuplestore_donestoring() which was
> introduced by commit dd04e95 21 years ago and SPI_push() and friends
> which were made no-ops macros by commit 1833f1a 7 years ago. Debian
> code search shows very minimal usages of these macros. Here's a patch
> attached to remove them.

I'm fine with this because all of these macros are no-ops for all supported
versions of Postgres.  Even if an extension is using them today, you'll get
the same behavior as before if you remove the uses and rebuild against
v12-v16.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com