Date: Thu, 16 Nov 2023 22:38:22 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jubilee Young <workingjubilee@gmail.com>,
	pgsql-hackers@lists.postgresql.org,
	John Naylor <johncnaylorls@gmail.com>
Subject: Re: Hide exposed impl detail of wchar.c
Message-ID: <20231117043822.GA2886723@nathanxps13>
References: <CAPNHn3oKJJxMsYq+qLYzVJOFrUcOr4OF1EC-KtFT-qh8nOOOtQ@mail.gmail.com>
 <20231116225402.GA2882846@nathanxps13>
 <450044.1700175990@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <450044.1700175990@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20231117043822.GA2886723%40nathanxps13>
Precedence: bulk

On Thu, Nov 16, 2023 at 06:06:30PM -0500, Tom Lane wrote:
> I'm generally sympathetic to the idea that simd.h was a rather large
> dependency to add to something as widely used as pg_wchar.h.  So I'd
> favor getting it out of there just on compilation-time grounds,
> independently of whether it's causing active problems.  That argument
> wouldn't justify a back-patch, but "it's causing problems" might.

Given the lack of evidence of anyone else using is_valid_ascii(), I'm
leaning towards back-patching being the better option in this case.  I
don't know if it'll be feasible to keep simd.h out of all headers that
third-party code might want to use forever, but that's not an argument
against doing this right now for pgrx.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com