Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5RoP-00DWWT-Hs for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Nov 2023 14:33:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r5RoN-00HKkO-VR for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Nov 2023 14:33:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5RoM-00HKih-JK for pgsql-hackers@lists.postgresql.org; Tue, 21 Nov 2023 14:33:11 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5RoJ-006efT-J0 for pgsql-hackers@postgresql.org; Tue, 21 Nov 2023 14:33:09 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 184915C0ADC; Tue, 21 Nov 2023 09:33:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 21 Nov 2023 09:33:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700577186; x= 1700663586; bh=fjXVUWBNIENiS+74t+pKd31Uh+6DeBGkj9KrburtiAs=; b=u qrk6QMQSF2dWIiRaQs8gojOypeC1n/lnhiEDyxfPwf1O1vyg/77escgrDo7sSS/l dYmc1ArI4BhnptRZ2ShT8Xe5Pm7bXCGBMwgzfNmWG6+AmhytCiEjhQ51wfcAcThc avRbV3AdqR8KuyY1uuHd9gOUnrzTopzdpWnHcyqtx3k3CJhMhCmJtFzI0qpwKxOC r0RciiwcyUn7qdQpKMI2pTDiFB8DRGbEi8NZBQQBFpRpY3v9Ub/3/JeQ7G0yWU2H WoAbQdI5txNTk7CgvI5A4A1yTixhTdpEnDVyeeLkFEslzZP9L/4HjWFMY/opidUp YlBuFrbhD0vwdNrEGje+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudegledgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Nov 2023 09:33:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1700577183; bh=aNu7a74Rlg2myv9VRhLtCxjRcezgilG8aKAk9KvDMwc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EJI9JqS/tV/GLF2gJDDwGMi55gURUrg3DT+p5qv4UHm5bsPgilINp2oWxeBKgSY2T 5bUXxxSwChcXbW8j27RM8YMkcpOkpCD/D6ClF1bLZynIhDk0+m5B92LzBEpC93+U1P gRBTPwh0GIGoxNPQcrEAn4fnAQ3Z3N5VEXWVUu0x2xL/ZrurTIpr1ObFA7J/cDL+F9 c6FjEPEU1VtFEeGTdYw7KX7El8ew5o02ZYwDnAfk3EP5y3Cllu3AhkvU5SbzZnMGMl NtbxHJm8YDCLRP69W2fPsVsUxZTFXMg2JGDjmBBzQ1E1MmD2MTXjuIsjVO5Ihzh6dS TsPvXy8/uAG/g== Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 15E67127; Tue, 21 Nov 2023 15:33:03 +0100 (CET) Date: Tue, 21 Nov 2023 15:33:03 +0100 From: Alvaro Herrera To: Hongxu Ma Cc: Michael Paquier , PostgreSQL Hackers Subject: Re: PSQL error: total cell count of XXX exceeded Message-ID: <202311211433.d5o7n6a25xtx@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-Sep-13, Hongxu Ma wrote: > After double check, looks `int64` of src/include/c.h is the proper type for it. > Uploaded the v4 patch to fix it. Right. I made a few more adjustments, including the additional overflow check in printTableInit that Tom Lane suggested, and pushed this. It's a bit annoying that the error recovery decision of this code is to exit the process with an error. If somebody were to be interested in a fun improvement exercise, it may be worth redoing the print.c API so that it returns errors that psql can report and recover from, instead of just closing the process. TBH though, I've never hit that code in real usage. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/