Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5ZPr-00E2Nl-4W for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Nov 2023 22:40:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r5ZPo-002pjQ-Pz for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Nov 2023 22:40:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5ZPo-002piP-DS for pgsql-hackers@lists.postgresql.org; Tue, 21 Nov 2023 22:40:20 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r5ZPf-007gCu-Uh for pgsql-hackers@postgresql.org; Tue, 21 Nov 2023 22:40:19 +0000 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-3575287211bso19312005ab.1 for ; Tue, 21 Nov 2023 14:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700606409; x=1701211209; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9qIzEo1ab+Xd9TTIMinLxzWqej4SmJn4GedvvE9dN94=; b=Mh3RE0OAYxhA7/ZK5mvdL2NI9uf+N9WRvOvzTsS9rj/lf/5eP9DmS2zmp6mYpy5BxY i0Ub1QGnjhbH8Q7KnN+sfz1ghH2FKTTvrZVHTbAMuzSpRNNzjRi8a4fIsUT/zWMd9mBD KsT9jFv07NnkdhrxMaoypYGD49F0DiVflW2vYhXTzJgt0Wo8McA6ayF3aFGjI7AkWwHk Ow380EMDBbn+SL2mMTD2aGl5M8j1yyXIFO3iOBQDruMlSioU6wN+vuz4pitkE4Hj1ngk 4xRkcGApTMdGaXTyFzoiKTrEM3BhOwWpdBFcds5+AhFZ6BBtSs6l6e8z8mi71j0lLhEy h4qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700606409; x=1701211209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9qIzEo1ab+Xd9TTIMinLxzWqej4SmJn4GedvvE9dN94=; b=iFn8m3hY8DqlLrwH7ws4gYh5EswgdDnCDLRXvgNGmIAtvpBrv7cUDVqLLtH9nzeebq 70KZxS7vP2XY/gB2CMaeqFO9lNUCwyRzLyQ51yh70lfqG4oIyaMUB5ug1EBnOTkvRJny DJyRLZabsDX+OK19trN4R6nB2UdY3fxAFZJ9tRG9siWaC1j5URINOf095ffkvKDVLL/n EDf0gwXBEClzlXYHZFJuBs970QjbXdZkP7VZdYaFMx3voB2dRWGjFoXD1FZY4H1pnUVs JNjlxshQvEhh5fA8M+A/4xCE9c3NMnhHudwCpG8MJlHWI6lK7sts/rzBOOW2bYkkAN1j T1mQ== X-Gm-Message-State: AOJu0Yy/eWMfDUCWPCYgcYRGn9EXzIAgZm9zVLXeFwDIIHMr62vtnCEZ Nvrgf23XMq56IojjEIhPk3b/soOC7E0= X-Google-Smtp-Source: AGHT+IGtThhhcKOK6tD3N7wZ/MBc4Tu6t8e1knhbEkEeDOpq4V5v6piCDiOqypY/KDENtzBEsb3aeg== X-Received: by 2002:a05:6e02:1145:b0:35b:41e:6357 with SMTP id o5-20020a056e02114500b0035b041e6357mr347006ill.14.1700606408966; Tue, 21 Nov 2023 14:40:08 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id f12-20020a056638022c00b0043193e32c78sm2768942jaq.152.2023.11.21.14.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 14:40:08 -0800 (PST) Date: Tue, 21 Nov 2023 16:40:06 -0600 From: Nathan Bossart To: pgsql-hackers@postgresql.org Cc: andres@anarazel.de, noah@leadboat.com Subject: Re: common signal handler protection Message-ID: <20231121224006.GA3747740@nathanxps13> References: <20231121212008.GA3742740@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121212008.GA3742740@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Nov 21, 2023 at 03:20:08PM -0600, Nathan Bossart wrote: > +#ifdef NSIG > +#define PG_NSIG (NSIG) > +#else > +#define PG_NSIG (64) /* XXX: wild guess */ > +#endif > + Assert(signo < PG_NSIG); cfbot seems unhappy with this on Windows. IIUC we need to use PG_SIGNAL_COUNT there instead, but I'd like to find a way to have just one macro for all platforms. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com