public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Xiang Gao <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: CRC32C Parallel Computation Optimization on ARM
Date: Thu, 30 Nov 2023 14:54:26 -0600
Message-ID: <20231130205426.GA1265417@nathanxps13> (raw)
In-Reply-To: <DB9PR08MB6991A568B076F056697C70B4F5B9A@DB9PR08MB6991.eurprd08.prod.outlook.com>
References: <20231031204821.GB78716@nathanxps13>
<DB9PR08MB69919D6CCCA3C66DBEEE0A7CF5A6A@DB9PR08MB6991.eurprd08.prod.outlook.com>
<20231102143550.GA2152@nathanxps13>
<DB9PR08MB69911391D134245352F01343F5A5A@DB9PR08MB6991.eurprd08.prod.outlook.com>
<20231106191613.GA524892@nathanxps13>
<DB9PR08MB69910E10543F4EEBAB13FBEAF5A9A@DB9PR08MB6991.eurprd08.prod.outlook.com>
<20231110163608.GA1225566@nathanxps13>
<DB9PR08MB6991A219E08040AC8D4159B8F5BAA@DB9PR08MB6991.eurprd08.prod.outlook.com>
<20231122210618.GA3751816@nathanxps13>
<DB9PR08MB6991A568B076F056697C70B4F5B9A@DB9PR08MB6991.eurprd08.prod.outlook.com>
On Thu, Nov 23, 2023 at 08:05:26AM +0000, Xiang Gao wrote:
> On Date: Wed, 22 Nov 2023 15:06:18PM -0600, Nathan Bossart wrote:
>>pg_crc32c_armv8.o: CFLAGS += ${CFLAGS_CRC} ${CFLAGS_CRYPTO}
>
> It does not work correctly. CFLAGS ='-march=armv8-a+crc,
> -march=armv8-a+crypto', what actually works is '-march=armv8-a+crypto'.
>
> We set a new variable CLAGS_CRC_CRYPTO,In configure.ac,
>
> If test x"$CFLAGS_CRC" != x"" || test x"CFLAGS_CRYPTO" != x""; then
> CLAGS_CRC_CRYPTO = '-march=armv8-a+crc+crypto'
> fi
>
> then in makefile,
> pg_crc32c_armv8.o: CFLAGS +=${ CLAGS_CRC_CRYPTO }
Ah, I see. We need to append +crc and/or +crypto based on what the
compiler understands. That seems fine to me...
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: CRC32C Parallel Computation Optimization on ARM
In-Reply-To: <20231130205426.GA1265417@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox