public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Robert Haas <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: UBSan pointer overflow in xlogreader.c
Date: Tue, 5 Dec 2023 15:01:41 -0600
Message-ID: <20231205210141.GA2762421@nathanxps13> (raw)
In-Reply-To: <CA+Tgmoat59LxYc3Yg6Rm9V=2Q3egfyyqouK_kcnea+QyBd9OdQ@mail.gmail.com>
References: <CA+hUKGKH0oRPOX7DhiQ_b51sM8HqcPp2J3WA-Oen=dXog+AGGQ@mail.gmail.com>
	<20231205180402.GB2757816@nathanxps13>
	<CA+Tgmoat59LxYc3Yg6Rm9V=2Q3egfyyqouK_kcnea+QyBd9OdQ@mail.gmail.com>

On Tue, Dec 05, 2023 at 03:48:33PM -0500, Robert Haas wrote:
> The patch LGTM, too. Thanks for investigating and writing the code.
> The part about how the reserved kernel memory prevents the bug from
> appearing on 32-bit systems but not 64-bit systems running in 32-bit
> mode is pretty interesting -- I don't want to think about how long it
> would have taken me to figure that out.

+1

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: UBSan pointer overflow in xlogreader.c
  In-Reply-To: <20231205210141.GA2762421@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox