Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBBzA-009n0T-3u for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Dec 2023 10:52:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rBBz8-00GhSI-SB for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Dec 2023 10:52:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBBz8-00GhS3-8d for pgsql-hackers@lists.postgresql.org; Thu, 07 Dec 2023 10:52:02 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBBz4-00AXrI-TT for pgsql-hackers@postgresql.org; Thu, 07 Dec 2023 10:52:01 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 64CEF5C0212; Thu, 7 Dec 2023 05:51:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Dec 2023 05:51:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701946316; x= 1702032716; bh=WMQmkc+VtuRPPm/fjPbVGnEHSYnghI3vSkI1JNN2Xdk=; b=e 3wpSE3ml7IjMl+Lf6lcBTwjY6rXTCRPvGGWBlelXgashpalEY5r/kfx1ApMZuYgX yJ8fJONvsouyr1pr0kotsDgYFuYklq1/Ewjtp/BkGJErFclW/q89Nu7s9FPgK22a IF5cArX7zJRTsV1nnA2gjOBikvJNIRS2vuKiAhdW6tj+yN+oOBsT8lPFbauGlCtQ WGKXBbE41hnVdxgjEOvPI+1Xlbx54yRW0YShH8NanX6ObKReTD3zGx+jE2nl5yxv OgH21veRyZ+aImCw5EWPjOG9Q1BjHdRGut8uW3JKqseR+EGGbGf1G6U0qRFQAzdV XCC6XBiYaxYclUrsTa1fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekvddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Dec 2023 05:51:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1701946313; bh=Iaz/tiBQ8h+pf9ZZphBrH2cZukQzXIeaKJURNvfoA54=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=liVX57rj10+oQf8cMTRPH5Yyk7YMIfVYj9F4v+drR6D/1A8EScemn3CyDop/R4qBR hsH9iM8+SYPx1jLAWpWoQc+k85llhCUd6ijlU4vJ6So6rKELVlRMgh68MC1/UcyniL itVNcDsHFdFsLMvsocHDVnbVxTPun7AQunL4w+/QGg72xKlTM8NEWr2Kc8/qYfVPcK cB056r6n8GSecPE6KtvSXnKQrrUDFcu1y4zNftkoR6Nigfa33FGRwcfRhM10vD1VOT 4fqskHGIJeIkseOrB2weR4y/Xmb4UcW7ykv6I2EMG/1KGYmqHq/slTaqbMXFK6UaGf Q8zQvFehJs5NQ== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id D386AC5; Thu, 7 Dec 2023 11:51:53 +0100 (CET) Date: Thu, 7 Dec 2023 11:51:53 +0100 From: Alvaro Herrera To: Erik Rijkers Cc: Amit Langote , jian he , Andres Freund , Andrew Dunstan , PostgreSQL-development Subject: Re: remaining sql/json patches Message-ID: <202312071051.cpxujwos4tlj@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-Dec-07, Erik Rijkers wrote: > Hm, this set doesn't apply for me. 0003 gives error, see below (sorrty for > my interspersed bash echoing - seemed best to leave it in. > (I'm using patch; should be all right, no? Am I doing it wrong?) There's definitely something wrong with the patch file; that binary file should not be there. OTOH clearly if we ever start including binary files in our tree, `patch` is no longer going to cut it. Maybe we won't ever do that, though. There's also a complaint about whitespace. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "El destino baraja y nosotros jugamos" (A. Schopenhauer)