Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBYtJ-00BLz1-SN for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Dec 2023 11:19:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rBYtH-00713m-Rp for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Dec 2023 11:19:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBYtH-00713e-GS for pgsql-hackers@lists.postgresql.org; Fri, 08 Dec 2023 11:19:31 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBYtD-009Oq7-Rm for pgsql-hackers@postgresql.org; Fri, 08 Dec 2023 11:19:29 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 437A83200ABA; Fri, 8 Dec 2023 06:19:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 08 Dec 2023 06:19:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702034365; x= 1702120765; bh=H55hqSP8PQcafvMew3UsZ3H+3rZWXnEyAAtbNB/DMgg=; b=2 JDb6lJfy1HOHBCPZmiiFze8ax80tJgKBa9bJR/w2XXtD4y4NzcAVlt+U8kqtC7YI 2ljG/NoxI+n912vmAHBYjEZHOU7GQDZOCcYUJILE9eU89+/jgmnYjTy+YtwCPaKh 1YDHSxvwGp+i+wWyrln5WMgFu6ShTidpj9OjtqQNdMhWBKwbEd4Tb5G0mXEdEQJL 8uE+iJYb74aq0WoEQJ9wMUUqA8CZM6+hkBdbB4L8HEkZh0MM1+g+LN3G9hfKAxTI Z3p2dq7AejGlE7867cH1fozBGK2laCe2bWy72I8118C7bj1/CqUNLk378xdrQDZi /9GpH4JfH0NJ06rb6vwlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekiedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Dec 2023 06:19:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1702034362; bh=xgrHrIkcEqtrVuoPsgD85gmToYLyNDkqwbxUZMpnDiY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=YM8qzwgEIa6Roo+f3PtH2SEoiCJkH/gFbWo6RETxh3eA2IHfAzlydbI2yzULDhagD 6AGxq0W+0VpgW6nCKGjqiYgSXWvaBlb0Wqs9/WFCl8gIsDBHZU4TCSd6S0WPWGJQeh YIRFcv2CdIOw8h0hmc/U1W2CqInXeCsAkxiVOn0CSkGbBIBAkaLUweyObURv9ue3tz PjnMtiIXqpPcWge8Kbo4wKWJz+EALq+fyu4iw83rngGLfDd0+1+HMjM7xfUDThxBYp 1A2LbdmqzuB/8ZRRVHSKXI8ok4W94hvfrBL+fV/ZChr7chLAAY7kx8fLv74qGm9XGZ XHzTe9yd045ig== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 9CE13C5; Fri, 8 Dec 2023 12:19:22 +0100 (CET) Date: Fri, 8 Dec 2023 12:19:22 +0100 From: Alvaro Herrera To: Greg Stark Cc: Nikolay Shaplov , PostgreSQL Hackers Subject: Re: [PATCH] minor reloption regression tests improvement Message-ID: <202312081119.gkzeuqtr44ap@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Mar-07, Greg Stark wrote: > I don't think this is worth spending time adding tests for. I get what > you're saying that this is at least semi-intentional behaviour and > desirable behaviour so it should have tests ensuring that it continues > to work. But it's not documented behaviour and the test is basically > testing that the implementation is this specific implementation. > > I don't think the test is really a bad idea but neither is it really > very useful and I think it's not worth having people spend time > reviewing and discussing. I'm leaning to saying this patch is > rejected. I've pushed this patch; I agree with Greg that this is semi-intentional and desirable, even if not documented. (I doubt we would document it anyway, as having previously SET an invalid option is not something that happens commonly; what reason would we have for documenting that it works to RESET such an option?) As for the implementation being this specific one, that's something already embedded in all of reloptions.sql, so I don't really mind that, if we do change it, we'll have to rewrite pretty much the whole file and not "the whole file except these three lines". Lastly, there is a long-running patch proposal to refactor reloptions quite significantly, so it'll be good to ensure that the new implementation doesn't break the features we already have; and this one corner is one thing Nikolay already said his patch had broken and failed to notice right away. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "La verdad no siempre es bonita, pero el hambre de ella sí"