Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFLX4-009S48-Jp for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Dec 2023 21:52:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFLX3-00D0WX-8T for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Dec 2023 21:52:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFLX2-00D0Vw-S6 for pgsql-hackers@lists.postgresql.org; Mon, 18 Dec 2023 21:52:12 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rFLWw-00B3xS-2a for pgsql-hackers@postgresql.org; Mon, 18 Dec 2023 21:52:11 +0000 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-35fb42a07f1so4800505ab.0 for ; Mon, 18 Dec 2023 13:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702936325; x=1703541125; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AxzPqO3vi14xMw7dumOjtBihOLfgwULOEjWx4IbVbQY=; b=Ez9QF1v+FHc//vFdwXj7oREOZeX4JePD47JgBBfk4SwbEbq/K9px04D0jYbKrdssxl VDTl1Ro5rPgu+siuR61RG9JLEPZdDu0aXwVIFaGPy6KZAOyCmshtMxcVOab3mvw8i/8o x/NBRtnO5npAT/VYkiaQeiizjZU243q//VJfwMoVPElkRZOhrEuESCLu+l0MHgadi2b9 6WV9oznnpkDwCU5YucmOxo2WwkKwz5xRRLxsjrokuJ8MhsgI5bNU0YUenVAtBS7EQ2H8 BW66KhiYXRXyrCfifZ9c48Yix2dGgVXozML0rk5lUidFO1kxohPSQsLFUkfBROT5+De8 K9Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702936325; x=1703541125; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AxzPqO3vi14xMw7dumOjtBihOLfgwULOEjWx4IbVbQY=; b=W5TMOe1eL9S6zSOyInq0rJL8KYon+PKbHvhrKyfFogaKoxf5zUFni3iTILKnps6sPl 1IbTgHihXH1eWANg3h7pDkqfNpylo16WjKxQ9qZzLlbrWITwLhS5qSvuSuBpvauyFSCh 8U2nXJSvIVuO1fXw4+5FYGo7IX3cRXfKC921PUlurGgkO+miGMo46B2Gn3iVxuX4AZjr oEXt6WTkyYuRkf9yN9VrIGOB8udvm8vvJG1FgWgZ+E53CIMDyKJfpFfUvGbx6RxVotSY hT8osygznBDiAmVLulZOUZkRUCCC4d0sNmVUn2Fr0OKuuU+6uOMh067RQA1vPgtJK15D ARmg== X-Gm-Message-State: AOJu0Yx4Q1rWtkvSX0T9DzIwvAYfCDfCfvPoDx1z5iA6960cAVS71sBS erd/Hes8HcO5F+Kfpbi+SKM= X-Google-Smtp-Source: AGHT+IEUrUmLIs2XiOsnI43egBlLTYBasGp47fk9yZBVO4V3pFokR1Br4PwwamUns3whLVkXpuVfZA== X-Received: by 2002:a05:6e02:1a68:b0:35f:b080:9cec with SMTP id w8-20020a056e021a6800b0035fb0809cecmr3160389ilv.0.1702936325197; Mon, 18 Dec 2023 13:52:05 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id bb10-20020a0566383b0a00b0046b4e38a630sm706238jab.109.2023.12.18.13.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 13:52:04 -0800 (PST) Date: Mon, 18 Dec 2023 15:52:01 -0600 From: Nathan Bossart To: Tom Lane Cc: Michael Paquier , Kyotaro Horiguchi , noah@leadboat.com, pgsql-hackers@postgresql.org Subject: Re: add non-option reordering to in-tree getopt_long Message-ID: <20231218215201.GA586573@nathanxps13> References: <20230710200658.GA362078@nathanxps13> <20230711.161609.1881651378858129172.horikyota.ntt@gmail.com> <20230711163232.GA616878@nathanxps13> <20230713034903.GA991765@nathanxps13> <20230713145712.GA1049722@nathanxps13> <20230714043842.GB327716@nathanxps13> <4007895.1702928482@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4007895.1702928482@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Dec 18, 2023 at 02:41:22PM -0500, Tom Lane wrote: > We just had a user complaint that seems to trace to exactly this > bogus reporting in pg_ctl [1]. Although I was originally not > very pleased with changing our getopt_long to do switch reordering, > I'm now wondering if we should back-patch these changes as bug > fixes. It's probably not worth the risk, but ... I'm not too concerned about the risks of back-patching these commits, but if this 19-year-old bug was really first reported today, I'd agree that fixing it in the stable branches is probably not worth it. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com