Date: Fri, 5 Jan 2024 00:14:15 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: verify predefined LWLocks have entries in wait_event_names.txt
Message-ID: <20240105061415.GA2167264@nathanxps13>
References: <20240102173120.GA1061678@nathanxps13>
 <ZZTHsd8-_L76GJ_a@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZTHsd8-_L76GJ_a@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20240105061415.GA2167264%40nathanxps13>
Precedence: bulk

On Wed, Jan 03, 2024 at 11:34:25AM +0900, Michael Paquier wrote:
> On Tue, Jan 02, 2024 at 11:31:20AM -0600, Nathan Bossart wrote:
>> +# Find the location of lwlocknames.h.
>> +my $include_dir = $node->config_data('--includedir');
>> +my $lwlocknames_file = "$include_dir/server/storage/lwlocknames.h";
> 
> I am afraid that this is incorrect because an installation could
> decide to install server-side headers in a different path than
> $include/server/.  Using --includedir-server would be the correct
> answer, appending "storage/lwlocknames.h" to the path retrieved from
> pg_config.

Ah, good to know, thanks.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com