Date: Mon, 8 Jan 2024 15:08:47 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: vignesh C <vignesh21@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers@postgresql.org
Subject: Re: Adding a pg_get_owned_sequence function?
Message-ID: <20240108210847.GA2796792@nathanxps13>
References: <87jzwcsasv.fsf@wibble.ilmari.org>
 <4970adf1-cdb0-9ae5-d405-e9c3395d9931@eisentraut.org>
 <2797313.1694529622@sss.pgh.pa.us>
 <87v8cfo32v.fsf@wibble.ilmari.org>
 <20231024162929.GA871220@nathanxps13>
 <CALDaNm0_nn-LXSJCXQ6EYiGKjVO8fVO8AemgEVZFQPPdx0=fkg@mail.gmail.com>
 <87a5pfn4o5.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87a5pfn4o5.fsf@wibble.ilmari.org>
Archived-At: <https://www.postgresql.org/message-id/20240108210847.GA2796792%40nathanxps13>
Precedence: bulk

On Mon, Jan 08, 2024 at 04:58:02PM +0000, Dagfinn Ilmari Mannsĺker wrote:
> We can't make pg_get_serial_sequence(text, text) not work on identity
> columns any more, that would break existing users, and making the new
> function not work on serial columns would make it harder for people to
> migrate to it.  If you're suggesting adding two new functions,
> pg_get_identity_sequence(regclass, name) and
> pg_get_serial_sequence(regclass, name)š, which only work on the type of
> column corresponding to the name, I don't think that's great for
> usability or migratability either.

I think these are reasonable concerns, but with this patch, we now have the
following functions:

	pg_get_identity_sequence(table regclass, column name) -> regclass
	pg_get_serial_sequence(table text, column text) -> text

If we only look at the names, it sure sounds like the first one only works
for identity columns, and the second only works for serial columns.  But
both work for identity _and_ serial.  The real differences between the two
are the parameter and return types.  Granted, this is described in the
documentation updates, but IMHO this is a kind-of bizarre state to end up
in.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com