pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feeddoc: add LITERAL tag to RETURNING
4+ messages / 3 participants
[nested] [flat]
* doc: add LITERAL tag to RETURNING
@ 2024-01-12 05:56 torikoshia <torikoshia@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: torikoshia @ 2024-01-12 05:56 UTC (permalink / raw)
To: pgsql-hackers
Hi,
RETURNING is usually tagged with appropriate tags, such as <LITERAL>,
but not in the 'query' section of COPY.
https://www.postgresql.org/docs/devel/sql-copy.html
Would it be better to put <LITERAL> here as well?
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
Attachments:
[text/x-diff] v1-0001-Added-literal-tag-for-RETURNING.patch (1.3K, ../../c0aa00b60a16c0ea2a4c5123b013acb9@oss.nttdata.com/2-v1-0001-Added-literal-tag-for-RETURNING.patch)
download | inline diff:
From 3c9efe404310bf01d79b2f0f006541ebc0b170a0 Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi <torikoshia@oss.nttdata.com>
Date: Fri, 12 Jan 2024 14:33:47 +0900
Subject: [PATCH v1] Added literal tag for RETURNING.
---
doc/src/sgml/ref/copy.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml
index 18ecc69c33..e2ffbbdf84 100644
--- a/doc/src/sgml/ref/copy.sgml
+++ b/doc/src/sgml/ref/copy.sgml
@@ -128,10 +128,10 @@ COPY { <replaceable class="parameter">table_name</replaceable> [ ( <replaceable
</para>
<para>
For <command>INSERT</command>, <command>UPDATE</command> and
- <command>DELETE</command> queries a RETURNING clause must be provided,
- and the target relation must not have a conditional rule, nor
- an <literal>ALSO</literal> rule, nor an <literal>INSTEAD</literal> rule
- that expands to multiple statements.
+ <command>DELETE</command> queries a <literal>RETURNING</literal> clause
+ must be provided, and the target relation must not have a conditional
+ rule, nor an <literal>ALSO</literal> rule, nor an
+ <literal>INSTEAD</literal> rule that expands to multiple statements.
</para>
</listitem>
</varlistentry>
base-commit: 08c3ad27eb5348d0cbffa843a3edb11534f9904a
--
2.39.2
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: doc: add LITERAL tag to RETURNING
@ 2024-01-12 06:22 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
parent: torikoshia <torikoshia@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: Ashutosh Bapat @ 2024-01-12 06:22 UTC (permalink / raw)
To: torikoshia <torikoshia@oss.nttdata.com>; +Cc: pgsql-hackers
On Fri, Jan 12, 2024 at 11:27 AM torikoshia <torikoshia@oss.nttdata.com> wrote:
>
> Hi,
>
> RETURNING is usually tagged with appropriate tags, such as <LITERAL>,
> but not in the 'query' section of COPY.
I have the same observation.
>
> https://www.postgresql.org/docs/devel/sql-copy.html
>
> Would it be better to put <LITERAL> here as well?
>
The patch looks good.
--
Best Wishes,
Ashutosh Bapat
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: doc: add LITERAL tag to RETURNING
@ 2024-01-12 11:56 Alvaro Herrera <alvherre@alvh.no-ip.org>
parent: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Alvaro Herrera @ 2024-01-12 11:56 UTC (permalink / raw)
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>; +Cc: torikoshia <torikoshia@oss.nttdata.com>; pgsql-hackers
On 2024-Jan-12, Ashutosh Bapat wrote:
> On Fri, Jan 12, 2024 at 11:27 AM torikoshia <torikoshia@oss.nttdata.com> wrote:
> >
> > RETURNING is usually tagged with appropriate tags, such as <LITERAL>,
> > but not in the 'query' section of COPY.
> The patch looks good.
Good catch, pushed. It has user-visible effect, so I backpatched it.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"People get annoyed when you try to debug them." (Larry Wall)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: doc: add LITERAL tag to RETURNING
@ 2024-01-15 01:48 torikoshia <torikoshia@oss.nttdata.com>
parent: Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 4+ messages in thread
From: torikoshia @ 2024-01-15 01:48 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>; pgsql-hackers
On 2024-01-12 20:56, Alvaro Herrera wrote:
> On 2024-Jan-12, Ashutosh Bapat wrote:
>
>> On Fri, Jan 12, 2024 at 11:27 AM torikoshia
>> <torikoshia@oss.nttdata.com> wrote:
>> >
>> > RETURNING is usually tagged with appropriate tags, such as <LITERAL>,
>> > but not in the 'query' section of COPY.
>
>> The patch looks good.
>
> Good catch, pushed. It has user-visible effect, so I backpatched it.
Thanks for your review and push.
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-01-15 01:48 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-01-12 05:56 doc: add LITERAL tag to RETURNING torikoshia <torikoshia@oss.nttdata.com>
2024-01-12 06:22 ` Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
2024-01-12 11:56 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2024-01-15 01:48 ` torikoshia <torikoshia@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox