Date: Fri, 12 Jan 2024 13:45:55 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Abhijit Menon-Sen <ams@toroid.org>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: introduce dynamic shared memory registry
Message-ID: <20240112194555.GA3804945@nathanxps13>
References: 
 <CA+TgmoZRber4XLQC6PaRneh5OECakguePcFD4YUg8qJ+jB+u=g@mail.gmail.com>
 <20240102224907.GA1246933@nathanxps13>
 <CALj2ACWc3Xb6v06T2jkJvEoA9W4aQ+0fY-8w78bY_Dq1ux6GDg@mail.gmail.com>
 <20240106163516.GB2435448@nathanxps13>
 <CALj2ACW4AcGcbwFzFr4RZ62PtcOj=Xg73Xmy_YDQya3g=xVDhQ@mail.gmail.com>
 <20240108171627.GA2611898@nathanxps13>
 <ZZ94oH_5L2rFAywl@paquier.xyz>
 <CALj2ACVaFuUys-Fkq8SQDpTOJnmaqO6C8RshbYtbW-DJD7LbAA@mail.gmail.com>
 <20240112172152.GA3803561@nathanxps13>
 <ZaF6UpYImGqVIhVp@toroid.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZaF6UpYImGqVIhVp@toroid.org>
Archived-At: 
 <https://www.postgresql.org/message-id/20240112194555.GA3804945%40nathanxps13>
Precedence: bulk

On Fri, Jan 12, 2024 at 11:13:46PM +0530, Abhijit Menon-Sen wrote:
> At 2024-01-12 11:21:52 -0600, nathandbossart@gmail.com wrote:
>> +      Each backend sould obtain a pointer to the reserved shared memory by
> 
> sould → should

D'oh.  Thanks.

>> +      Add-ins can reserve LWLocks on server startup.  Like with shared memory,
> 
> (Would "As with shared memory" read better? Maybe, but then again maybe
> it should be left alone because you also write "Unlike with" elsewhere.)

I think "As with shared memory..." sounds better here.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com