Date: Fri, 12 Jan 2024 16:56:35 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Kumar, Sachin" <ssetiya@amazon.com>, Jan Wieck <jan@wi3ck.info>,
	Bruce Momjian <bruce@momjian.us>, Zhihong Yu <zyu@yugabyte.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Magnus Hagander <magnus@hagander.net>,
	Robins Tharakan <tharakan@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade failing for 200+ million Large Objects
Message-ID: <20240112225635.GA4033820@nathanxps13>
References: <20220908231807.GA2242918@nathanxps13>
 <CAAWbhmgUb8p7ff_ZX5jCvqM=ipPxbbDJTXMNVzH-Ho_CXVkRHA@mail.gmail.com>
 <0643CC11-223A-4039-AC34-94E127462796@amazon.com>
 <1152134.1699555261@sss.pgh.pa.us>
 <83D44BE5-0088-4D41-8AE6-20A05D026F46@amazon.com>
 <81D13E16-BA04-43CF-9B89-B8924300B211@amazon.com>
 <240D05EC-8B28-4112-BEAB-85ECBAF3F871@amazon.com>
 <2055911.1702258962@sss.pgh.pa.us>
 <534746.1703116064@sss.pgh.pa.us>
 <20240112224227.GA3857154@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240112224227.GA3857154@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20240112225635.GA4033820%40nathanxps13>
Precedence: bulk

On Fri, Jan 12, 2024 at 04:42:27PM -0600, Nathan Bossart wrote:
> On Wed, Dec 20, 2023 at 06:47:44PM -0500, Tom Lane wrote:
>> +			char	   *cmdEnd = psprintf(" OWNER TO %s", fmtId(te->owner));
>> +
>> +			IssueCommandPerBlob(AH, te, "ALTER LARGE OBJECT ", cmdEnd);
> 
> This is just a nitpick, but is there any reason not to have
> IssueCommandPerBlob() accept a format string and the corresponding
> arguments?

Eh, I guess you'd have to find some other way of specifying where the OID
is supposed to go, which would probably be weird.  Please disregard this
one.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com