Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rPkIk-00DqvN-7r for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jan 2024 14:20:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rPkIj-004G7D-DU for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jan 2024 14:20:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rPkIj-004G75-3w for pgsql-hackers@lists.postgresql.org; Tue, 16 Jan 2024 14:20:25 +0000 Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rPkIg-001pGO-N4 for pgsql-hackers@postgresql.org; Tue, 16 Jan 2024 14:20:23 +0000 Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-3608bdb484fso24798365ab.1 for ; Tue, 16 Jan 2024 06:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705414821; x=1706019621; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jcqQoQObTlTvG1rfm41awGFazwcC7i9/8K0TXTHtGzs=; b=PEsYj2anDwmlcvOQSILlHvDm0KSCnofuh+HfjokdsRSo3H7SJ+TbfJfmIleKW5M6Lh 2SZGd8Dl0FtEJKzmHpnTDycSCIQ7DArUpsd6R6JWB0bPOA7S2h9VjbYHfEpgVsCOgCYX UsUhSQHRIAOSn1p68SGc7Vskq/FL/IViKSxVuRVdx+YeHm+fCGLdCnLcE0AYPBF6KtFv 3BwwEzf1Oam0fp4yxSIUsjLnRsvQVxyO9lRbTvIe2FVbWHyBC9an+Q5dw+hU0wy3XqRA aetZG/8SiyYmBFUyQa7bPj8mfllW6+A7CNkJotw/HAmnoHjPxRm6u4Voh7jREdJB93/p g0sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705414821; x=1706019621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jcqQoQObTlTvG1rfm41awGFazwcC7i9/8K0TXTHtGzs=; b=Fs74S8Y4IsIgo+N/tBaBRJXQVcjnBiAxtnaoXMFfogq1vB6AU2S6lxiRShrUbH9K69 45NI0GaRUOSdMbI1pfkS0Tt3Woi2diZ/p/ukmF0cSljtLJJ2xoesqP4Q8sbBeo0rVj+y FANexh5KytEmYhPPUM6fPFWSqwLrPgVyGI4GdRpfOv/FVH6RWZhgxLpu232GU9f7BzXB 5fND5Klu7Y6bHWdcdMwOpFR7TCnW8TwDQrF9LDcJiW0rKNXpPoEaGBA3njX6iJRpIk5x 4McKB67zFW7KKN+n/R+Gp1qGmkhLq39KmaEgTzO8qBDsX5vyXLPkjJljdi5WAVEQm6fO 2iGA== X-Gm-Message-State: AOJu0YzUDyMmNDbiqxMUHObbeffLFiHgmMtv7LxsjmMcVKIbu1M9fsu7 RnJcxg9cl579IAhIxkp/C3Q= X-Google-Smtp-Source: AGHT+IG+Hg8ra03H3+wraTJt9s8Q3TImYw/KyxSu1r8/tptXcGVymuTp1Lbnfy6LWIOkuTSqeVUnuw== X-Received: by 2002:a05:6e02:1bed:b0:360:8a0b:50dc with SMTP id y13-20020a056e021bed00b003608a0b50dcmr4528545ilv.10.1705414821410; Tue, 16 Jan 2024 06:20:21 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id v16-20020a92c810000000b003606cb03c2bsm3546119iln.74.2024.01.16.06.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 06:20:20 -0800 (PST) Date: Tue, 16 Jan 2024 08:20:19 -0600 From: Nathan Bossart To: Bharath Rupireddy Cc: Aleksander Alekseev , pgsql-hackers@postgresql.org Subject: Re: reorganize "Shared Memory and LWLocks" section of docs Message-ID: <20240116142019.GA52506@nathanxps13> References: <20240112041430.GA3557928@nathanxps13> <20240112154650.GA3565306@nathanxps13> <20240112172350.GB3803561@nathanxps13> <20240113212815.GA4065002@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jan 16, 2024 at 10:02:15AM +0530, Bharath Rupireddy wrote: > The v3 patch looks good to me except for a nitpick: the input > parameter for RequestAddinShmemSpace is 'Size' not 'int' > > > void RequestAddinShmemSpace(int size) > Hah, I think this mistake is nearly old enough to vote (e0dece1, 5f78aa5). Good catch. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com