Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQPxf-0015u9-PD for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2024 10:49:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rQPxe-001osf-K3 for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2024 10:49:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQPxd-001osW-5n for pgsql-hackers@lists.postgresql.org; Thu, 18 Jan 2024 10:49:26 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQPxZ-0028du-Tx for pgsql-hackers@lists.postgresql.org; Thu, 18 Jan 2024 10:49:23 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 09FF85C01D8; Thu, 18 Jan 2024 05:49:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 18 Jan 2024 05:49:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1705574961; x= 1705661361; bh=t4wXMI8Jf5AmZgGSRXwFmd0iYBaOiMM7IyYi1/AOWDc=; b=N REJ4JCMcvSTYlkzh00T6+r7SUjq2Gfvhi+1oc0bkxFxeklLJzBYiMAV1xDIeVsyu /srVsEq1Nn4fOFdU7AVw2NseRM4YANlqSuAXHtiuHHNhQbbbTyVip3MVbNIrGUiH /mNmyC0RBkRw5iSAVEHkEkVqI1VcOPno7vI2qEzUJlJE7vOd8Q+7nBGJNunJolhr /mH8AgEgntUVxdteVaEMjnQmRecNrhF/HwyxtoZI2rZxwRwfvUtDIJ+5XTuMKnjP kGo2X+PkBtUOkk2mERkCIahWs6INrQr4tWNiPJLaf6NYnk0jx8kCYyHCSTqo9YDf wBAhcNvkjVqAG12Kf8uIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdejjedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 18 Jan 2024 05:49:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1705574958; bh=9MsMbLPWIa9zG8nazhdoK+pra8gX+zj7J1AYNv3XNjo=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=B5CoMd8u8YTGayjLVSsG+bQbZPf0Acbzw6XzcW8L95jeGYdrKoJ+IYS2aMNTQau3q oTCpTLXL86O25e+GvACEKfvNmFMBsO8lAN8FpYftHFi5XzWMV2186wRaBaTiOZl13R EqgyVXgzBMLz33SfNc/ooHA2snoRxbSiFBq6LDuHmoOZvzlTlm0EiSSH7uX850Cnfx f9TA8HbdGHJrkdDiSFCs6fEfaNa33516n8Tqqt940YFKUYgA62TQRfVQjulgH3UrH/ WIEEKDt9WXk1Vwa+ja3VHKWju8sLUWIwYsqUuJvIagM8HKrfT53/vEVDr0mY8S/5xk hF9DSD1/OmCbQ== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 30FA691; Thu, 18 Jan 2024 11:49:18 +0100 (CET) Date: Thu, 18 Jan 2024 11:49:18 +0100 From: Alvaro Herrera To: Bharath Rupireddy Cc: Pg Hackers Subject: Re: minor replication slot docs edits Message-ID: <202401181049.el2j6ez663dp@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Jan-16, Bharath Rupireddy wrote: > Thanks for the patch. The wording looks good to me. However, I have > some comments on the placement of the note: > > 1. How about bundling this in a or ? Yeah, I considered this too, but I discarded the idea because my impression of and was that they attract too much attention off the main text; it should be the other way around. But that's not really something for this patch to solve, and we use boxes in many other places and nobody complains about this. So I made it a . > 2. I think the better place for this note is at the end after the > "Similarly, on its own, > without" paragraph. It will then be like we introduce what replication > slot is and why it is better over other mechanisms to retain WAL and > then caution the users of it retaining WAL. Makes sense. I have pushed it. I made one other terminology change from "primary" to "primary server", but only in that subsection. We use "primary" as a standalone term extensively in other sections of this chapter, and I don't like it very much, but I didn't want to make this more invasive. Another thing I noticed is that we could change all (or most of) the tags to , but it's also a much larger change. Having (some of?) these variable names be links would be useful IMO. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/