public inbox for [email protected]  

help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: Nathan Bossart <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Subject: Re: Improve WALRead() to suck data directly from WAL buffers when possible
Date: Mon, 22 Jan 2024 12:12:18 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACWPKuoUdA7r4VFKhsTZeNekyUr=ZwM6ckyvJ0qv2f6Whg@mail.gmail.com>
References: <CALj2ACV123Ke6wn05QCnCgJhFpcarGCv7sKM1p39t+qpUNHUgQ@mail.gmail.com>
	<[email protected]>
	<CALj2ACUSydTHPcucftm4XdiJ4osH8zeNENyADd-zfDzEMf6akA@mail.gmail.com>
	<[email protected]>
	<CALj2ACXo-_boM3h-PJuvfuvFzP1nv2wcZBoZN_YbRbQBGQYAUg@mail.gmail.com>
	<CALj2ACVfFMfqD5oLzZSQQZWfXiJqd-NdX0_317veP6FuB31QWA@mail.gmail.com>
	<[email protected]>
	<CALj2ACXy5eA-Y4Qgm3MUYZTGr_opNm2SzGtN+Zj6dbcSzqHrJA@mail.gmail.com>
	<[email protected]>
	<CALj2ACWPKuoUdA7r4VFKhsTZeNekyUr=ZwM6ckyvJ0qv2f6Whg@mail.gmail.com>

Hi,

On 2024-01-10 19:59:29 +0530, Bharath Rupireddy wrote:
> +		/*
> +		 * Typically, we must not read a WAL buffer page that just got
> +		 * initialized. Because we waited enough for the in-progress WAL
> +		 * insertions to finish above. However, there can exist a slight
> +		 * window after the above wait finishes in which the read buffer page
> +		 * can get replaced especially under high WAL generation rates. After
> +		 * all, we are reading from WAL buffers without any locks here. So,
> +		 * let's not count such a page in.
> +		 */
> +		phdr = (XLogPageHeader) page;
> +		if (!(phdr->xlp_magic == XLOG_PAGE_MAGIC &&
> +			  phdr->xlp_pageaddr == (ptr - (ptr % XLOG_BLCKSZ)) &&
> +			  phdr->xlp_tli == tli))
> +			break;

I still think that anything that requires such checks shouldn't be
merged. It's completely bogus to check page contents for validity when we
should have metadata telling us which range of the buffers is valid and which
not.

Greetings,

Andres Freund





view thread (22+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Improve WALRead() to suck data directly from WAL buffers when possible
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox