Feedback-ID: id4a34324:Fastmail
Date: Mon, 22 Jan 2024 13:29:10 -0800
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Network failure may prevent promotion
Message-ID: <20240122212910.llghcvr3x4itlett@awork3.anarazel.de>
References: <20231231.200218.1749113750714588065.horikyota.ntt@gmail.com>
 <20231231.200741.1078989336605759878.horikyota.ntt@gmail.com>
 <20240118.172631.1740094280436463079.horikyota.ntt@gmail.com>
 <99ac4a55-0ea3-41e5-b1bd-fca8dcd84e3c@iki.fi>
 <ZansRcusW27eHDXh@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZansRcusW27eHDXh@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20240122212910.llghcvr3x4itlett%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2024-01-19 12:28:05 +0900, Michael Paquier wrote:
> On Thu, Jan 18, 2024 at 03:42:28PM +0200, Heikki Linnakangas wrote:
> > Given that commit 728f86fec6 that introduced this issue was not strictly
> > required, perhaps we should just revert it for v16.
> 
> Is there a point in keeping 728f86fec6 as well on HEAD?  That does not
> strike me as wise to keep that in the tree for now.  If it needs to be
> reworked, looking at this problem from scratch would be a safer
> approach.

IDK, I think we'll introduce this type of bug over and over if we don't fix it
properly.

Greetings,

Andres Freund