Date: Mon, 22 Jan 2024 20:46:52 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Abhijit Menon-Sen <ams@toroid.org>,
	Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: introduce dynamic shared memory registry
Message-ID: <20240123024652.GA2251765@nathanxps13>
References: <ZaF6UpYImGqVIhVp@toroid.org>
 <20240112194555.GA3804945@nathanxps13>
 <20240113214124.GA4162765@nathanxps13>
 <CALj2ACVKFPm7nCrHMko7JJpsFJU23abzYyMS8S2Pz8r4M=rW7w@mail.gmail.com>
 <20240116160748.GB100542@nathanxps13>
 <CALj2ACWuiAm7Rr13PFfaiQfOHUoCbJOJvU72jyLnj4xfoEOAEg@mail.gmail.com>
 <20240119204636.GA1178173@nathanxps13>
 <3348869.1705854106@sss.pgh.pa.us>
 <20240121221320.GA1682397@nathanxps13>
 <CALj2ACVv9ADZ=yBcL3LPT+tkepwujfk_s3mLidzXcE5smpjwfg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CALj2ACVv9ADZ=yBcL3LPT+tkepwujfk_s3mLidzXcE5smpjwfg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20240123024652.GA2251765%40nathanxps13>
Precedence: bulk

On Mon, Jan 22, 2024 at 05:00:48PM +0530, Bharath Rupireddy wrote:
> On Mon, Jan 22, 2024 at 3:43 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> Oops.  I've attached an attempt at fixing this.  I took the opportunity to
>> clean up the surrounding code a bit.
> 
> The code looks cleaner and readable with the patch. All the call sites
> are taking care of dsm_attach returning NULL value. So, the attached
> patch looks good to me.

Committed.  Thanks for the report and the reviews.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com