Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSj5v-00FXQC-JW for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Jan 2024 19:39:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rSj5t-007kv4-IE for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Jan 2024 19:39:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSj5t-007kuo-8b for pgsql-hackers@lists.postgresql.org; Wed, 24 Jan 2024 19:39:29 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rSj5q-003WWm-EM for pgsql-hackers@lists.postgresql.org; Wed, 24 Jan 2024 19:39:28 +0000 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7bee328027bso197159839f.1 for ; Wed, 24 Jan 2024 11:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706125164; x=1706729964; darn=lists.postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=gzv6U6iEaVQM3isIXT0u2xq50jK4n2MoAdZJ/xcaLaE=; b=Kw3uUaNm429qfvPQisJcYXZ7dps5gKioUBFgKQr7VUZVAXojsbEjSqz4maR9VbIi6R B004T4dnd9lFrKCraCL1x/Tkt21/RXjttUEbKM6Hv8szSJeKPz4gnWuDovt2RlZP6Sdr 9skiFGvwXVj0s5CHqj5S8jto+aAyKitmtSGjCj+BJou7uiSd+hu3IQLYUTlFGgPFzMXK sDA38HteLlkGf7YPTArxVOkB8Zd0derbY5R5GFFJPizgaeVs5oRkZjZTBMx1hR1fKnQp 1VDW5UEf+aIG+VlBgFLWoIBEgrNmS29AaNh9xAT+QoMu/wt1RX+GdqDSSQLC1lC8No/3 qIbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706125164; x=1706729964; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gzv6U6iEaVQM3isIXT0u2xq50jK4n2MoAdZJ/xcaLaE=; b=b9XUpxu8uyUSpQBdTPoycQOus6seTRFurI5LO66iH4S3thc+jRf2WKVJfmTHC9FWxk 1gqP/gIEkNbWNn5kQdEFYgSK7lNrjZMGYmnL51TtQ0yFTTPxd8C8scbdaxWbb/wFFqoQ SxL8EBAQVnScQlzH42FqzOWK2mm+EDJ4u23sqUyG3E0xWRQgihu5N45nM31tJXp0QYED 4YOwgUjTGEaMGNaX9CQj25p9KSxJJIEratf1mQIC5FRRQvLGi4amNIMkwM9N3o7OUd3w SDZnzNofY/kW62K5W9BCOgglN7pLjcdgg6eNDL3tQvS6PNeFM01Fga7briKilkANxOWk RFtw== X-Gm-Message-State: AOJu0Yy151ZorgoDjixKaF7qUSUH/7VbirTubD9D253s6q6ALirY4t2e xlkphk+0QAVeasQoKBxzWT51fuNtqre9BhNaKKBDg8WzqyKXoNra X-Google-Smtp-Source: AGHT+IEO2e7QpZKy+sOt+Snwao/ZhrdT7u8jA+4gGS8UT42lRkOyi+dPVcxTyXhjkiMr8AoYmYv4TQ== X-Received: by 2002:a05:6602:2bc6:b0:7be:f401:2dd0 with SMTP id s6-20020a0566022bc600b007bef4012dd0mr2600400iov.13.1706125164389; Wed, 24 Jan 2024 11:39:24 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id k26-20020a02335a000000b0046f1a8aa7a2sm219015jak.43.2024.01.24.11.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 11:39:24 -0800 (PST) Date: Wed, 24 Jan 2024 13:39:22 -0600 From: Nathan Bossart To: Robert Haas Cc: Matthias van de Meent , PostgreSQL Hackers Subject: Re: cleanup patches for incremental backup Message-ID: <20240124193922.GA2711912@nathanxps13> References: <20240124170846.GA2643050@nathanxps13> <20240124180515.GA2709722@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jan 24, 2024 at 02:08:08PM -0500, Robert Haas wrote: > On Wed, Jan 24, 2024 at 1:05 PM Nathan Bossart wrote: >> Otherwise, I think we'll probably need to add some additional logging to >> figure out what is happening... > > Where, though? I suppose we could: > > 1. Change the server code so that it logs each WAL summary file > removed at a log level high enough to show up in the test logs. > > 2. Change the TAP test so that it prints out readdir(WAL summary > directory) at various points in the test. That seems like a reasonable starting point. Even if it doesn't help determine the root cause, it should at least help rule out concurrent summary removal. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com