Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT2Hi-00HZAK-8a for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jan 2024 16:08:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rT2Hh-000zR4-AX for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jan 2024 16:08:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT2Hg-000zPq-U5 for pgsql-hackers@lists.postgresql.org; Thu, 25 Jan 2024 16:08:57 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rT2He-003fqs-5D for pgsql-hackers@lists.postgresql.org; Thu, 25 Jan 2024 16:08:56 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d74678df08so29663505ad.1 for ; Thu, 25 Jan 2024 08:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706198932; x=1706803732; darn=lists.postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aEBEXKs+BzXIkYtsfqSyuPTHae8+jKRY/Nwjr+JAicM=; b=BjM3V4BmlfxWBSp797POdsp0o/t8JeYO1DGJxHZjg1BUkeQh31AZK+RRx1/E4PEvfv bpircji1CkKvyStm3nIZ09aja1Yni1pz56j87MaZ8Md+O8nENcHr8frzO2uhzk5D5ttt Ex6BMJzVVYnreZTOb522PnFhbZ+TUmszkpdGycKDDd2b4TmLY+nBV+/i38RFjSiiUCOM RtNu/T0vLE9SmNymWuYpyIDS5ogCgAKXlspkHH6MB2frfpIkFp7wJzgTMtCszUumK6Gz KVyFqBdaNA4MZlE8wFghXuhY41R7Oa0LSoEsyLSrsQZeAiiLJzOct1AZC0MyiqlMl562 PPdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706198932; x=1706803732; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aEBEXKs+BzXIkYtsfqSyuPTHae8+jKRY/Nwjr+JAicM=; b=UKCyEW57Zo1zt313OlDs8K0syOLDLh1H10ubxeH1AZ1bW6YY9WyCFK5H1K+JkAVh0N 15IgTJkHS7+XwzixfyhwelWgZsj9vgYDp1mLbWGtSgjn8Gs/WV39DbYbf0QbN9AKI1Da F0W5oHx39UepYbnyoacsBSRNV6d7e8+UgX6VEexCHrrb1GYir28eyfSX5Pw475ngc4JM aw3Y6Q8kr6nScAPtmWU29KQLP3BHK5aaBhNheNdFpUB7MfNfwsAD8WZq+HK6lF0P4IL8 KWstcA2giv708LquGjX8MZVa440dosYDPTe7t7INo0RoxfLDGDSUaMNMT6LyI1gN7KQ1 SEtg== X-Gm-Message-State: AOJu0YzTDZ39yEU7/kzgxZ8aRfM4NRmt8fQpCsjmKPlzYp7/IO0tgLHe wmJPTCRLfJqVaaue5g+rlzVL8PCYtIfVjRbf4v8maMlFvDbVEvFv X-Google-Smtp-Source: AGHT+IG+mQZwYKdkNTkyz7DhEPyxGJmRxLB7pMSpJyVynQL8CzGbKGcO8ayQy1v/0bt+lfRuYPjwjA== X-Received: by 2002:a17:903:2402:b0:1d7:199:cfb1 with SMTP id e2-20020a170903240200b001d70199cfb1mr950181plo.53.1706198931853; Thu, 25 Jan 2024 08:08:51 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id w15-20020a056638138f00b0046f34d6a528sm24712jad.28.2024.01.25.08.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 08:08:51 -0800 (PST) Date: Thu, 25 Jan 2024 10:08:50 -0600 From: Nathan Bossart To: Robert Haas Cc: Matthias van de Meent , PostgreSQL Hackers Subject: Re: cleanup patches for incremental backup Message-ID: <20240125160850.GA2729380@nathanxps13> References: <20240124170846.GA2643050@nathanxps13> <20240124180515.GA2709722@nathanxps13> <20240124193922.GA2711912@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jan 25, 2024 at 10:06:41AM -0500, Robert Haas wrote: > On Wed, Jan 24, 2024 at 2:39 PM Nathan Bossart wrote: >> That seems like a reasonable starting point. Even if it doesn't help >> determine the root cause, it should at least help rule out concurrent >> summary removal. > > Here is a patch for that. LGTM. The only thing I might add is the cutoff_time in that LOG. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com