Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rTQAZ-002o0W-U5
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jan 2024 17:39:12 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rTQAY-000lHo-QC
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jan 2024 17:39:10 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1rTQAY-000lHg-Hc
	for pgsql-hackers@lists.postgresql.org; Fri, 26 Jan 2024 17:39:10 +0000
Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1rTQAV-003rOM-Hz
	for pgsql-hackers@lists.postgresql.org; Fri, 26 Jan 2024 17:39:09 +0000
Received: by mail-il1-x12b.google.com with SMTP id
 e9e14a558f8ab-361a741722bso936085ab.1
        for <pgsql-hackers@lists.postgresql.org>;
 Fri, 26 Jan 2024 09:39:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1706290746; x=1706895546;
 darn=lists.postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=EXsmSmfyE02Cg3/aycKdRH1wSzFWG+RTbB9kenAfGHU=;
        b=Qw8YnBtrLBmQ95/TN9mDsS53G/g7oq0jg7QNYj0IlVkc8uUtL4M0mtI/njwwYQV/yZ
         KtIJc6IkuNJnPjsI3PliE7+mNHlMJJZZBEhpxKbqFXpHUH/LIwlGpUUwdMtxIaVswjA7
         tgfGg/N5iiDBlULlkJKqhVcfK0UzbpozJSNpTbkxE72OQEw7CtTmdU/m9wQmZ/zf/Gk5
         gWMKc+9WlRb9eX/9dCiJaKq9oczQROvFxvQRzoT6yUVw6Jb+s1DdAPbWY/jNs2nViJVs
         w5gU2z3Jjd6N9W6ikYE90aAh7PmUqEBqGf7D70h+VI8dTheUqvWdbigjXeCYG3crxXW9
         CTcQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1706290746; x=1706895546;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=EXsmSmfyE02Cg3/aycKdRH1wSzFWG+RTbB9kenAfGHU=;
        b=qXBP6BgIHIoEQTVVoxcVIoyLEe6w9S9e7oNKxjHSxLYUIgayNoxJErAvLPVX4p/slK
         alkj3o2jwLbE3PzcoipCOgVZbHvOfwrhUoUsQJNS7uNV6dBs6yBnz1RuI1NZfTOIPESi
         i0gDl/LM6qVLtm1ERNx7kEskRqfyv1+6rPCnriNpBpXc/uA8yDhyvDzgxidXXsHVFxJQ
         iXjDPspXYZtHj9DvpoWL8qESXL04f15WfFIZFlWG2t49pgDvQxndiXI8T9eCmQ4qTUj2
         dSaEQF5qnNBEl+ZsX8M2lyaeUdVbGnMUi2xNPmU9wXxejJEE5MyxUT/mwBg/w98dtFN+
         IuMw==
X-Gm-Message-State: AOJu0YwUzNlMnnHIOb5NSv1ZuCNSqfsH4ToYRZAt9PHkLuZg+s5EpDdZ
	TiHWd+E6Y3es6zG0ioRary4iA+OBt1tS7MTNnssQ7oHJWb8kPTHM
X-Google-Smtp-Source: 
 AGHT+IGdfAefnAppW+1eT3xDdejxhSBBGOYJgAJ8wgVEhKnNHC7Gupt3eU1IjhpircY6JR/DcFWIlA==
X-Received: by 2002:a92:d348:0:b0:35f:b96d:641e with SMTP id
 a8-20020a92d348000000b0035fb96d641emr130518ilh.12.1706290745731;
        Fri, 26 Jan 2024 09:39:05 -0800 (PST)
Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net.
 [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id
 e16-20020a92d750000000b00362902d6818sm417127ilq.62.2024.01.26.09.39.05
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 26 Jan 2024 09:39:05 -0800 (PST)
Date: Fri, 26 Jan 2024 11:39:04 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: cleanup patches for incremental backup
Message-ID: <20240126173904.GA2765759@nathanxps13>
References: 
 <CAEze2WjhdVCqEe_qqEok3NA6DwUdOGSBjAxzmYdAqiaaH1uRcg@mail.gmail.com>
 <CA+TgmoaQHtGNFczJzSO5sMobUpuikSHphtFPZpdLmjzwdmM1DQ@mail.gmail.com>
 <20240124170846.GA2643050@nathanxps13>
 <CA+TgmoZusu5g3rM1k=UB29Sf53c1OKjm1uFw9uo-sSXBLFZJiQ@mail.gmail.com>
 <20240124180515.GA2709722@nathanxps13>
 <CA+TgmobWwfMpog9Yz=krBT1=sobGzWNxuEiCXg4Hh92fNOMHJw@mail.gmail.com>
 <20240124193922.GA2711912@nathanxps13>
 <CA+TgmoaC39=6Mc=b4zGVn86r7-1YPZtYQf=fVPaKdEXrA2i0dA@mail.gmail.com>
 <20240125160850.GA2729380@nathanxps13>
 <CA+TgmoZLXsorAX2XNxC1+zKFSagCZUk4Qiq49+WxTk8oePvWCQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoZLXsorAX2XNxC1+zKFSagCZUk4Qiq49+WxTk8oePvWCQ@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20240126173904.GA2765759%40nathanxps13>
Precedence: bulk

On Fri, Jan 26, 2024 at 11:04:37AM -0500, Robert Haas wrote:
> Here is v2 with that addition.

Looks reasonable.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com