Feedback-ID: ia2694551:Fastmail
Date: Mon, 5 Feb 2024 10:53:17 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Lakhin <exclusion@gmail.com>,
	Dean Rasheed <dean.a.rasheed@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: cataloguing NOT NULL constraints
Message-ID: <202402050953.vxb2dfgzimht@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202402050950.q367e2d6rtjs@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202402050953.vxb2dfgzimht%40alvherre.pgsql>
Precedence: bulk

On 2024-Feb-05, Alvaro Herrera wrote:

> Subject: [PATCH v1] Fix failure to merge NOT NULL constraints in inheritance
> 
> set_attnotnull() was not careful to CommandCounterIncrement() in cases
> of multiple recursion.  Omission in b0e96f311985.

Eh, this needs to read "multiple inheritance" rather than "multiple
recursion".  (I'd also need to describe the change for the partitioning
cases in the commit message.)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Someone said that it is at least an order of magnitude more work to do
production software than a prototype. I think he is wrong by at least
an order of magnitude."                              (Brian Kernighan)