Date: Mon, 5 Feb 2024 17:22:56 +0900
From: Yugo NAGATA <nagata@sraoss.co.jp>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: jian he <jian.universality@gmail.com>, "David G. Johnston"
 <david.g.johnston@gmail.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Message-Id: <20240205172256.0942c4e8b757fc6f7c4dbfa8@sraoss.co.jp>
In-Reply-To: <04bf425ad1b15a4daefe96c478a5253b@oss.nttdata.com>
References: <CAKFQuwawy1e6YR4S=j+y7pXqg_Dw1WBVrgvf=BP3d1_aSfe_+Q@mail.gmail.com>
	<20240129172858.ccb6c77c3be95a295e2b2b44@sraoss.co.jp>
	<CACJufxFFU92-H7G8tmpxt9oTSfL062OA7n5rPx-YbOAtDUUzGw@mail.gmail.com>
	<04bf425ad1b15a4daefe96c478a5253b@oss.nttdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240205172256.0942c4e8b757fc6f7c4dbfa8%40sraoss.co.jp>
Precedence: bulk

On Mon, 05 Feb 2024 11:28:59 +0900
torikoshia <torikoshia@oss.nttdata.com> wrote:

> > Based on this, I've made a patch.
> > based on COPY Synopsis: ON_ERROR 'error_action'
> > on_error 'null', the  keyword NULL should be single quoted.
> 
> As you mentioned, single quotation seems a little odd..
> 
> I'm not sure what is the best name and syntax for this feature, but 
> since current error_action are verbs('stop' and 'ignore'), I feel 'null' 
> might not be appropriate.

I am not in favour of using 'null' either, so I suggested to use
"set_to_null" or more generic syntax like  "set_to (col, val)" in my
previous post[1], although I'm not convinced what is the best either.

[1] https://www.postgresql.org/message-id/20240129172858.ccb6c77c3be95a295e2b2b44%40sraoss.co.jp

Regards,
Yugo Nagata

-- 
Yugo NAGATA <nagata@sraoss.co.jp>