Date: Tue, 06 Feb 2024 09:39:09 +0900 (JST)
Message-Id: <20240206.093909.1866377550429411676.horikyota.ntt@gmail.com>
To: nagata@sraoss.co.jp
Cc: torikoshia@oss.nttdata.com, jian.universality@gmail.com,
 david.g.johnston@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <20240205172256.0942c4e8b757fc6f7c4dbfa8@sraoss.co.jp>
References: <CACJufxFFU92-H7G8tmpxt9oTSfL062OA7n5rPx-YbOAtDUUzGw@mail.gmail.com>
	<04bf425ad1b15a4daefe96c478a5253b@oss.nttdata.com>
	<20240205172256.0942c4e8b757fc6f7c4dbfa8@sraoss.co.jp>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240206.093909.1866377550429411676.horikyota.ntt%40gmail.com>
Precedence: bulk

At Mon, 5 Feb 2024 17:22:56 +0900, Yugo NAGATA <nagata@sraoss.co.jp> wrote in 
> On Mon, 05 Feb 2024 11:28:59 +0900
> torikoshia <torikoshia@oss.nttdata.com> wrote:
> 
> > > Based on this, I've made a patch.
> > > based on COPY Synopsis: ON_ERROR 'error_action'
> > > on_error 'null', the  keyword NULL should be single quoted.
> > 
> > As you mentioned, single quotation seems a little odd..
> > 
> > I'm not sure what is the best name and syntax for this feature, but 
> > since current error_action are verbs('stop' and 'ignore'), I feel 'null' 
> > might not be appropriate.
> 
> I am not in favour of using 'null' either, so I suggested to use
> "set_to_null" or more generic syntax like  "set_to (col, val)" in my
> previous post[1], although I'm not convinced what is the best either.
> 
> [1] https://www.postgresql.org/message-id/20240129172858.ccb6c77c3be95a295e2b2b44%40sraoss.co.jp

Tom sugggested using a separate option, and I agree with the
suggestion. Taking this into consideration, I imagined something like
the following, for example.  Although I'm not sure we are actually
going to do whole-tuple replacement, the action name in this example
has the suffix '-column'.

COPY (on_error 'replace-colomn', replacement 'null') ..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center