Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rXOhk-00AQs2-0a for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Feb 2024 16:53:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rXOhi-005Jkj-VI for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Feb 2024 16:53:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rXOhi-005Jka-Lo for pgsql-hackers@lists.postgresql.org; Tue, 06 Feb 2024 16:53:50 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rXOhf-005nQe-KS for pgsql-hackers@lists.postgresql.org; Tue, 06 Feb 2024 16:53:49 +0000 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-363cc7efdf7so6875055ab.2 for ; Tue, 06 Feb 2024 08:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707238425; x=1707843225; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1i87vV0bMOk92wiOboEkUkbFpI4b4oHsn9W2i8c6KhQ=; b=h4DVUSFkwBytyyE+h8bW03OUj3H5QEqElExlwNYBOzCTY+juJ2fEV1Zy4tAFL9ECwQ KRzEw6LioebE/BmZDhuCAuz6UEgCrOHHHSTIvMMR7vuqsdNLNf0Hp+AJd9AgGpq8KYyf ZgPlQEnbSbsWW7zw4RMMPLxNRBVMje3u1snQKm3rBbcoE8CuK5H1U3lcfJFIQoKEJvQt S7kqkT2Hu25ZcCSKfpGH8xbtIzkNi1ZeaDQSduD0c2oCUq6ONY+jd76IS0/0g3MqNm/m MLNvee0fM74m+LBIhyKRK20TIUMVaYVnAf9oPVkLI/42+BBSSsLivtZw3b2nY2mp4JpZ 7JMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707238425; x=1707843225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1i87vV0bMOk92wiOboEkUkbFpI4b4oHsn9W2i8c6KhQ=; b=JQhvKXjZHVUtlsIhFW2BFGRIBuPQ5xFK2Xr4w6tDR0fAUgQV9dujd+pYo+yAC2Togi q9b2vCGC/VjxSOpS9ykk3OXEQzZg5dmZfn9o2jBCYQwbXVBwEetMmonSLBFxFEIECdP+ lhN2SDMb8wS0TQxEUAR4iLzlair2IQiJpLJKwGnq5mbJpbA6dn2KocR7m+tXexP532iR /K1l5Jw+7aAbUATda4cdLbk2r0sjDxDOUcvT3oRs5oSRKLJvVfKI6WLalMhJNZpibAyi r4UUH2SQwfu3y1E6dwp+t+tssYIsZC7NSjvM+MMkvsL5AVBEdfMl6G6miASlrhy0wxYw gM/g== X-Gm-Message-State: AOJu0YxG3OwFBsALIgkchdRWDbopyxtfAUllEyWFV9iSXeUh3A8NxKUG NTJ9bxItqiIYMevvMuE+FvTVvvOLdVEkNKxMBBtwWls61rS0TRJBGpZWhFJS X-Google-Smtp-Source: AGHT+IEGmv1xh6HXWxNRzstSaV4b8eXWjzzdwpWNtDDfObLtjAcKiqhlzPsTEGmHlmHVApp3PwnqNA== X-Received: by 2002:a05:6e02:970:b0:363:c9f7:bcc2 with SMTP id q16-20020a056e02097000b00363c9f7bcc2mr3348135ilt.10.1707238425366; Tue, 06 Feb 2024 08:53:45 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX4D5dx44cJEXSX/QwQBUBFC4M/TFP62MzVIb7DoloQ1eYjzAf5nEuNjVMW2bSKQzdWBKJFR+TyzDufjVAQoFI7ATemamsIso7wrVAAhz6x8JwG Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id dh10-20020a056e021f0a00b00363797f6b00sm67241ilb.8.2024.02.06.08.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 08:53:44 -0800 (PST) Date: Tue, 6 Feb 2024 10:53:43 -0600 From: Nathan Bossart To: Michael Banck Cc: Laurenz Albe , pgsql-hackers@lists.postgresql.org Subject: Re: Set log_lock_waits=on by default Message-ID: <20240206165343.GA3841415@nathanxps13> References: <659ffa38.170a0220.eea6a.28fc@mx.google.com> <65b146b9.170a0220.c645b.0891@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65b146b9.170a0220.c645b.0891@mx.google.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I saw this was marked ready-for-committer, so I took a look at the thread. It looks like there are two ideas: * Separate log_lock_waits from deadlock_timeout. It looks like this idea has a decent amount of support, but I didn't see any patch for it so far. IMHO this is arguably a prerequisite for setting log_lock_waits on by default, as we could then easily set it higher by default to help address concerns about introducing too much noise in the logs. * Set log_lock_waits on by default. The folks on this thread seem to support this idea, but given the lively discussion for enabling log_checkpoints by default [0], I'm hesitant to commit something like this without further community discussion. [0] https://postgr.es/m/CALj2ACX-rW_OeDcp4gqrFUAkf1f50Fnh138dmkd0JkvCNQRKGA%40mail.gmail.com -- Nathan Bossart Amazon Web Services: https://aws.amazon.com