Date: Wed, 7 Feb 2024 11:15:54 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, noah@leadboat.com
Subject: Re: common signal handler protection
Message-ID: <20240207171554.GA153000@nathanxps13>
References: <20231121212008.GA3742740@nathanxps13>
 <20240207023941.GA67817@nathanxps13>
 <20240207024853.pg55gxzmqxi3nrmr@awork3.anarazel.de>
 <20240207170650.GA80671@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240207170650.GA80671@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20240207171554.GA153000%40nathanxps13>
Precedence: bulk

Sorry for the noise.

On Wed, Feb 07, 2024 at 11:06:50AM -0600, Nathan Bossart wrote:
> I'd like to get this committed (to HEAD only) in the next few weeks.  TBH
> I'm not wild about the weird caveats (e.g., race conditions when pqsignal()
> is called within a signal handler), but I also think it is unlikely that
> they cause any issues in practice.  Please do let me know if you have any
> concerns about this.

Perhaps we should add a file global bool that is only set during
wrapper_handler().  Then we could Assert() or elog(ERROR, ...) if
pqsignal() is called with it set.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com