Feedback-ID: ia2694551:Fastmail
Date: Fri, 9 Feb 2024 11:19:03 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Maiquel Grassi <grassi@hotmail.com.br>
Cc: Erik Wienhold <ewie@ewie.name>, Jim Jones <jim.jones@uni-muenster.de>, 
	Pavel Luzanov <p.luzanov@postgrespro.ru>, Nathan Bossart <nathandbossart@gmail.com>, 
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Psql meta-command conninfo+
Message-ID: <202402091019.y3psh2m7sqbv@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CP8P284MB249681AA87D9EAF9412439D9EC442@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM>
Archived-At: <https://www.postgresql.org/message-id/202402091019.y3psh2m7sqbv%40alvherre.pgsql>
Precedence: bulk

Hmm, I noticed that this would call printSSLInfo() and printGSSInfo()
after listConnectionInformation.  It would be much better to show these
in tabular format as well and remove the calls to printSSL/GSSInfo.

I propose additional columns to the same \conninfo+ table; when SSL,
like this:

Database           | postgres
[...]
Host               | 127.0.0.1
Encryption         | SSL
Protocol           | PQsslAttribute(protocol)
Cipher             | PQsslAttribute(cipher)
Compression        | PQsslAttribute(compression)

When GSS, like this

Database           | postgres
[...]
Host               | 127.0.0.1
Encryption         | GSS

(why don't we print anything else in printGSSInfo()?  That's weird.)

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Pido que me den el Nobel por razones humanitarias" (Nicanor Parra)