public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Pavlo Golub <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: [PATCH] allow pg_current_logfile() execution under pg_monitor role
Date: Fri, 9 Feb 2024 10:36:57 -0600
Message-ID: <20240209163657.GC663211@nathanxps13> (raw)
In-Reply-To: <CAK7ymcLmEYWyQkiCZ64WC-HCzXAB0omM=Ypj9B3rXe8vUAFMqw@mail.gmail.com>
References: <CAK7ymcLmEYWyQkiCZ64WC-HCzXAB0omM=Ypj9B3rXe8vUAFMqw@mail.gmail.com>

On Fri, Feb 09, 2024 at 04:01:58PM +0100, Pavlo Golub wrote:
> The patch attached fixes an oversight/inconsistency of disallowing the
> pg_monitor system role to execute pg_current_logfile([text]).

I think this is reasonable.  We allow pg_monitor to execute functions like
pg_ls_logdir(), so it doesn't seem like much of a stretch to expect it to
have privileges for pg_current_logfile(), too.  Are there any other
functions that pg_monitor ought to have privileges for?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] allow pg_current_logfile() execution under pg_monitor role
  In-Reply-To: <20240209163657.GC663211@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox