Date: Fri, 9 Feb 2024 14:04:29 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Mats Kindahl <mats@timescale.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: glibc qsort() vulnerability
Message-ID: <20240209200429.GA665650@nathanxps13>
References: 
 <CA+14424k0MbdkJuSSLrr1==PYK+oL5Gtq7siTsMgCs+KcCrEvA@mail.gmail.com>
 <20240208183835.GA503311@nathanxps13>
 <1074897.1707417842@sss.pgh.pa.us>
 <20240208195954.vlpoii4ftoow2of4@awork3.anarazel.de>
 <20240208200737.GA504276@nathanxps13>
 <1242426.1707424769@sss.pgh.pa.us>
 <CA+14425sEcy-KzCE1ztpO=XrHZ5u_5tR2UNsw6874dVbAShpzQ@mail.gmail.com>
 <20240209162433.GA663211@nathanxps13>
 <1596756.1707496048@sss.pgh.pa.us>
 <CA+14426fF6Mx0cM1vi47WLi3qtkNvtmr7DAkCpqVk0x41P9z-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+14426fF6Mx0cM1vi47WLi3qtkNvtmr7DAkCpqVk0x41P9z-A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20240209200429.GA665650%40nathanxps13>
Precedence: bulk

On Fri, Feb 09, 2024 at 08:40:47PM +0100, Mats Kindahl wrote:
> On Fri, Feb 9, 2024 at 5:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We do pretty much assume that "int" is "int32".  But I agree that
>> assuming anything about the width of size_t is bad.  I think we need
>> a separate pg_cmp_size() or pg_cmp_size_t().
> 
> Do we want to have something similar for "int" as well? It seems to be
> quite common and even though it usually is an int32, it does not have to be.

I don't think we need separate functions for int and int32.  As Tom noted,
we assume they are the same.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com