Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rZdHG-005aGS-V2
	for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Feb 2024 20:51:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rZdHG-00DIhj-3j
	for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Feb 2024 20:51:46 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1rZdHF-00DIhb-RV
	for pgsql-hackers@lists.postgresql.org; Mon, 12 Feb 2024 20:51:45 +0000
Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1rZdHC-006rxT-Sa
	for pgsql-hackers@lists.postgresql.org; Mon, 12 Feb 2024 20:51:45 +0000
Received: by mail-io1-xd2f.google.com with SMTP id
 ca18e2360f4ac-7baa8da5692so183362939f.0
        for <pgsql-hackers@lists.postgresql.org>;
 Mon, 12 Feb 2024 12:51:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1707771101; x=1708375901;
 darn=lists.postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=7EzaTAOmxtWZfS0VVFbMXxJw4RWBJpTBnPuc8pBxVz0=;
        b=LJuzGUKctLIyrVCqjo/b9z5tAwoBAWzzM3qVbXNVsGIXMAHAb/ngR40BKXBHhrXkXe
         2AKjBeIGjDlwALsk003V4fjtljCiPyTb/Id4L1RpmLh+VurqX1UK0bJROZmHMbKGsJ5Q
         p15t/KpaEvswcEdjznJixeQQE2SrFJpuT3W1CDVpRSWLUsrPX4gaHt7SNcNYaHTMMi1Q
         WlpQAppb3efs0KX45UwUUjEJ9SDbTCBnFyB0dYrk2odaZdk5O4mzRkaj+Bm4PNWfKltz
         Mn6vHOzjqqFlWcOUQB4wv0zjkEjKxOsssd0j/BgTeFWNDEyk2upAHzm2SF5Y09WTtpA+
         shvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1707771101; x=1708375901;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=7EzaTAOmxtWZfS0VVFbMXxJw4RWBJpTBnPuc8pBxVz0=;
        b=wm47NhTx1Spe+bNL2NIjkmW7jnqaxLga2JJvBex5YkYXrdGbgnzBkKxEVoGWAQWGne
         VF3U8wcb2nyXqymuhtBFxGGyATF8MMVsb53OLmqLD5lUR6WlSaPefBuQkXw+2mkJZYgD
         FcXkqyxAbsu9gO+HEMudw/OtD4UCbEEDyKpQaq2BkIYyWVRHo3I8e364cCe8OgubzPbR
         JbTJzy5hUFMQa+0aqYAaz9Bes0h5pASaEqi0BTUhee456BR8kx6MkYR2eu1whs3J3AAP
         a/WyfaoUT3q8AiFQ2uCk9J9EeqCSsw4sc7K8angI17ldAON9D/DSKsuBDMzK0TZRepJp
         iNKA==
X-Forwarded-Encrypted: i=1;
 AJvYcCW1/xOr69Ytt0BytagxRpmzxMZILMb9y/Gnn4zOij+TEcqgPTfh3reLv9MEi8ia6VR3SHUM6AX9QYrOVUArIYBkfEtrRQZP9vS+1r0AZSGCULex
X-Gm-Message-State: AOJu0YzJ7EVfpt2p5OjfgN35P8HAdT1VVD8o3eSqu63WVp6EwheycLrE
	0rA/ry/tuS4eLO2W7NkTPDKheKXgTFwQNLhp2ZG+jBusdEOEK2H4
X-Google-Smtp-Source: 
 AGHT+IGtco8fcS1g/AlfXLbilqK0X3SymSWTLSEGjpk2lQoYMvbnvAnAo6ZlRcAyICVFf9VNl9AIzg==
X-Received: by 2002:a05:6602:2f07:b0:7c4:47b1:9c5f with SMTP id
 q7-20020a0566022f0700b007c447b19c5fmr12854134iow.20.1707771100812;
        Mon, 12 Feb 2024 12:51:40 -0800 (PST)
X-Forwarded-Encrypted: i=1;
 AJvYcCVg9uyObk1vf0LVuLcsDQvkV/dl9XDNf+QbZkKz7A6QJvT47ym8TeM9slsS0yttRPgfLzAQfOW4cM5fiEOTZdz+Yft+nuMnTwte2gKu+WWVoPnvSXyXdjLdhBR08jLr27JPrLQz8WypGCjIyWSGy7Qln7uAv7Bl7Y5h+A300q6JJQ90sW+m1+cfef0mzj1pKA==
Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net.
 [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id
 v10-20020a056638358a00b00472c7130ccesm1574490jal.143.2024.02.12.12.51.40
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 12 Feb 2024 12:51:40 -0800 (PST)
Date: Mon, 12 Feb 2024 14:51:38 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Mats Kindahl <mats@timescale.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: glibc qsort() vulnerability
Message-ID: <20240212205138.GA1815383@nathanxps13>
References: 
 <CA+14425sEcy-KzCE1ztpO=XrHZ5u_5tR2UNsw6874dVbAShpzQ@mail.gmail.com>
 <20240209162433.GA663211@nathanxps13>
 <CA+14427pVjvgnVGiyM45e_EyKgCmzgRiK3dSQJqfOtHAnY8Maw@mail.gmail.com>
 <CA+14427QfHELBNskJKPHA96yOJ6aUZE_XqbFBC7hz+hmywTtPQ@mail.gmail.com>
 <20240209200828.GB665650@nathanxps13>
 <CA+14425kn0RxC62M7ZaD5BRzBJEPRRLQQB4DGdL+=vxHS1E81Q@mail.gmail.com>
 <20240210205332.GA1124797@nathanxps13>
 <CA+14427j_ExhaicH96i3k8OnZaHYkYQtPm-Q66BzY96W3qBJ-A@mail.gmail.com>
 <20240212155715.GB1645880@nathanxps13>
 <CA+14426fK=NNECQDo7cmRHi5CfhRQcUqprfrzhat9MK2dYXK+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+14426fK=NNECQDo7cmRHi5CfhRQcUqprfrzhat9MK2dYXK+A@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20240212205138.GA1815383%40nathanxps13>
Precedence: bulk

On Mon, Feb 12, 2024 at 06:09:06PM +0100, Mats Kindahl wrote:
> Here are the two fixed patches.

These patches look pretty good to me.  Barring additional feedback, I'll
plan on committing them in the next few days.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com