Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raKKc-009Ero-RZ for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Feb 2024 18:50:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1raKKa-0086sX-OH for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Feb 2024 18:50:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raKKa-0086sP-F8 for pgsql-hackers@lists.postgresql.org; Wed, 14 Feb 2024 18:50:04 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1raKKX-007COi-9i for pgsql-hackers@postgresql.org; Wed, 14 Feb 2024 18:50:03 +0000 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7beda6a274bso160739f.2 for ; Wed, 14 Feb 2024 10:50:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707936598; x=1708541398; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lCOi49bGRV+Yt47V66l3eYZcLXr6Y686VtvDLHFZuo4=; b=AyupFybZAw91S+Bn25FjxN7DIP/SyLWPKQV3Vkm+R4kVd53HrN4gAQiGDtAtfTY4RM Ysks66+cV0EnNhojA8ZlFZkbBZHT5OzTa6wYuuw+NBapu4B44e9Qn30p3S5x1bW7ZMGj GixlvR5NokkCC1X+U98V0wV58kELbF0QURiaC9XpWAwlu/7BdsXrCAyVufQHSXgnsF1F An5vSjMIe7cdSXIrzZAoq3DG/rPSieneIm/S/DWncXTFHQVgs534HgmPgE1QMh3/uTn1 wkn4Rr5HxnfXX9gLiBxRbquFSqgMYM/fkCRkf3ixMmqur0CFuCluPMZyo1O57BW736OA uuNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707936598; x=1708541398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lCOi49bGRV+Yt47V66l3eYZcLXr6Y686VtvDLHFZuo4=; b=S2cmOLXBjpGbOLNN4c9ax4AHdkjBKVrZd36BglQh9PX2Q3LNpBx340utyINhTSwv4I 4rU1cHA7pRAPVFFXHuvwqQcFjGzmLEUBQ7ew76S5D69sLZ0dNeWXCZlPQeVP7oFZpdcB 8RSQcBByE7/+SP8shJZVqNgvUfa/H1ussOoNHjldQ/T78KHKqewmDLb9c6J/UU57wCQq VrRh/atK+BYamDp8ZLigJB/kHpwnyi2SLoTjSHC9pru80/5dTWgCyF4QnSui6U8N7du2 KiqK+aUZ+Th1dkDlsbVvB9kyLUGUedS8ZnloTGwW8FYzYySeqkmn+vXROL+gpE8GBkp7 E6eA== X-Forwarded-Encrypted: i=1; AJvYcCWtod05gZwg7CA5tMJNszTxpZcoB3xu/UQnJ17QM4/vRLlKq23VpQQ+4zixAT0D8+b5BgYPbvGAKYHLBOtXIIJPjuYm9LZd35BUnKH0 X-Gm-Message-State: AOJu0Yyl/kdglI76nXRo6adQm75ezm2s6YcYWvFrEqLptomdBFNju/fB mKLoEn/tEi2V2KPSg22Li+kq4zBVyGmmZl6BWWJvIJ1sYcd6/4AzrtibiTmz X-Google-Smtp-Source: AGHT+IHKTEZG7RMOKcA2dI0aEGS2h8ckJaHTzjV/+k6kbAa4V5IxWmjYkgUQ59/Sqhcz3QjKT4LwTQ== X-Received: by 2002:a6b:6610:0:b0:7c4:3b9e:f766 with SMTP id a16-20020a6b6610000000b007c43b9ef766mr3590323ioc.20.1707936598113; Wed, 14 Feb 2024 10:49:58 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU6uop5kVwkGsx4roUM15KFabfiZ9H1ZAJMOd3iloccOBLW8NuhO0rFlF6sMPt+cOzVe1G71ZLTzc86dgvJYOKe416UlIJWQWL+OciL Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id l13-20020a056638144d00b0046ecafac861sm2586273jad.153.2024.02.14.10.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 10:49:57 -0800 (PST) Date: Wed, 14 Feb 2024 12:49:56 -0600 From: Nathan Bossart To: Tom Lane Cc: Pavlo Golub , pgsql-hackers Subject: Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role Message-ID: <20240214184956.GA372883@nathanxps13> References: <20240209163657.GC663211@nathanxps13> <20240212154945.GA1645880@nathanxps13> <20240213212928.GA262402@nathanxps13> <2991602.1707936331@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2991602.1707936331@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Feb 14, 2024 at 01:45:31PM -0500, Tom Lane wrote: > "Pavlo Golub" writes: >> Oh, thanks! I forgot, indeed, to update docs and catalog version! My >> bad! > > Docs, yes, but don't include catversion bumps in submitted patches. > They'll just lead to merge problems when somebody else changes the > current catversion. We rely on the committer to remember to do this > (which is an imperfect system, but...) +1, I only included it in the patch I posted so that I didn't forget it... -- Nathan Bossart Amazon Web Services: https://aws.amazon.com