Feedback-ID: ia2694551:Fastmail
Date: Tue, 20 Feb 2024 11:53:20 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: 'Euler Taveira' <euler@eulerto.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 vignesh C <vignesh21@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
 Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>,
	=?utf-8?B?RmFicsOtemlv?= de Royes Mello <fabriziomello@gmail.com>
Subject: Re: speed up a logical replica setup
Message-ID: <202402201053.6jjvdrm7kahf@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <TYCPR01MB12077756323B79042F29DDAEDF54C2@TYCPR01MB12077.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202402201053.6jjvdrm7kahf%40alvherre.pgsql>
Precedence: bulk

On 2024-Feb-16, Hayato Kuroda (Fujitsu) wrote:

> 15.
> 
> You said in case of failure, cleanups is not needed if the process exits soon [1].
> But some functions call PQfinish() then exit(1) or pg_fatal(). Should we follow?

Hmm, but doesn't this mean that the server will log an ugly message that
"client closed connection unexpectedly"?  I think it's nicer to close
the connection before terminating the process (especially since the
code for that is already written).

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"We’ve narrowed the problem down to the customer’s pants being in a situation
 of vigorous combustion" (Robert Haas, Postgres expert extraordinaire)