Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rd2lg-003XXO-5V for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Feb 2024 06:41:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rd2le-008YGN-ID for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Feb 2024 06:41:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rd2ld-008YGF-E6 for pgsql-hackers@lists.postgresql.org; Thu, 22 Feb 2024 06:41:14 +0000 Received: from mail.clear-code.com ([153.126.206.245]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rd2lY-000IIE-FQ for pgsql-hackers@postgresql.org; Thu, 22 Feb 2024 06:41:13 +0000 Received: from localhost (unknown [IPv6:2404:7a80:89c1:1200:6af9:2266:1443:f149]) by mail.clear-code.com (Postfix) with ESMTPSA id 00F47186763; Thu, 22 Feb 2024 15:40:57 +0900 (JST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.clear-code.com 00F47186763 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clear-code.com; s=default; t=1708584058; bh=8XlcEL8ADoDu0GJRyZxUVpmxqjXPQGVMqlsrkIeYbyI=; h=Date:To:Cc:Subject:From:In-Reply-To:References:From; b=G0lB8uLwq1f6zv+nRHSqEmJ6lnspH7Gu+pUNI9uruMBBMxFMCNNc7v7NjtpH4Xc6v IO3IW9AsXfxhBMc9KgHiXt4ALSJwM6iGWeH6w8FyzHrLb4oKRFOmx0V9Mvm4+s3sDh pfrMmpqEwIexqUSUnY9hKZBMxrUGBGKr5FwuSmD4= Date: Thu, 22 Feb 2024 15:40:55 +0900 (JST) Message-Id: <20240222.154055.1131795475268328752.kou@clear-code.com> To: andres@anarazel.de Cc: robertmhaas@gmail.com, laurenz.albe@cybertec.at, tgl@sss.pgh.pa.us, jack@jncsoftware.com, david@fetter.org, jeff.janes@gmail.com, pgsql-hackers@postgresql.org Subject: Re: Why is pq_begintypsend so slow? From: Sutou Kouhei In-Reply-To: <20240219195351.5vy7cdl3wxia66kg@awork3.anarazel.de> References: <20240218200906.zvihkrs46yl2juzf@awork3.anarazel.de> <20240219.100252.1610549091537921652.kou@clear-code.com> <20240219195351.5vy7cdl3wxia66kg@awork3.anarazel.de> X-Mailer: Mew version 6.8 on Emacs 29.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Server: mail.clear-code.com X-Rspamd-Queue-Id: 00F47186763 X-Rspamd-Action: no action X-Spamd-Result: default: False [3.90 / 999.00]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:2518, ipnet:2404:7a80::/29, country:JP]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_COUNT_ZERO(0.00)[0]; TAGGED_RCPT(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; URIBL_BLOCKED(0.00)[localhost:helo,anarazel.de:email]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,cybertec.at,sss.pgh.pa.us,jncsoftware.com,fetter.org,postgresql.org]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; SURBL_MULTI_FAIL(0.00)[localhost:server fail,anarazel.de:server fail] List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, In <20240219195351.5vy7cdl3wxia66kg@awork3.anarazel.de> "Re: Why is pq_begintypsend so slow?" on Mon, 19 Feb 2024 11:53:51 -0800, Andres Freund wrote: >> I don't have a strong opinion how to implement this >> optimization as I said above. It seems that you like your >> approach. So I withdraw [1]. Could you complete this >> optimization? Can we proceed making COPY format extensible >> without this optimization? It seems that it'll take a little >> time to complete this optimization because your patch is >> still WIP. And it seems that you can work on it after making >> COPY format extensible. > > I don't think optimizing this aspect needs to block making copy extensible. OK. I'll work on making copy extensible without this optimization. > I don't know how much time/energy I'll have to focus on this in the near > term. I really just reposted this because the earlier patches were relevant > for the discussion in another thread. If you want to pick the COPY part up, > feel free. OK. I may work on this after I complete making copy extensible if you haven't completed this yet. Thanks, -- kou